Giter VIP home page Giter VIP logo

Comments (4)

RehanSaeed avatar RehanSaeed commented on May 30, 2024

Not sure about this one. Structs often implement ToString() or should if they don't already, so I'm not sure that using reflection would always provide better results.

We could add this as an option but we'd have to add some code to check that the struct is not primitive. I'm not sure how we could do that, we could check by namespace I suppose.

Also, FYI, the changlog.md file needs updating after you released. I noticed you also updated the releases GitHub page. It might be worth sticking to one method to avoid differences.

from serilog.exceptions.

krajek avatar krajek commented on May 30, 2024

Regarding CHANGELOG.md, yes, I forgot about putting 4.0.0 in there. Now it is done.
Regarding GitHub releases: CHANGELOG.md will be a definitive source of truth. Release pages are just a convenient way to start a release and create a tag.

Regarding structures: I am asking because I was surprised when I did characterization tests for the destructuring of struct. Obviously, nobody asked for the feature yet, so I will put the idea on the shelf.

from serilog.exceptions.

RehanSaeed avatar RehanSaeed commented on May 30, 2024

I wonder how JSON.NET implements this feature:
https://stackoverflow.com/questions/13804230/json-net-struct-serialization-discrepancy

from serilog.exceptions.

krajek avatar krajek commented on May 30, 2024

@RehanSaeed at the time I started the issue I thought it would be useful. However, in almost two years of using Serilog.Exceptions on every single project I never thought about or needed the feature. Closing.

from serilog.exceptions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.