Isomorphic example about found-relay HOT 8 CLOSED

Got some better logging and found that createResolver(fetcher) is returning an object with:

lastQueries: [ undefined, undefined ],

from found-relay.

More logging

/src/modern/Resolver

...
async * resolveElements(match) {
    console.log('MATCH', match);
...

Output:

MATCH { location: { action: 'POP', pathname: '/', search: '', hash: '', query: {} },
  routeIndices: [ 0, 0 ],
  routeParams: [ {}, {} ],
  params: {},
  routes:
   [ Route { path: '/', Component: [Object], children: [Object] },
     Route { Component: [Function: HomePage] } ],
  match:
   { location: { action: 'POP', pathname: '/', search: '', hash: '', query: {} },
     routeIndices: [ 0, 0 ],
     routeParams: [ {}, {} ],
     params: {} },
  router:
   { push: [Function],
     replace: [Function],
     go: [Function],
     createHref: [Function],
     createLocation: [Function],
     addTransitionHook: [Function: addHook],
     matcher: Matcher { routeConfig: [Object] },
     isActive: [Function: isActive] },
  context: undefined }

from found-relay.

1. Are the fetch requests actually succeeding on the server?
2. Does this work if you don't use SSR? That pathname thing seems unrelated to anything you might be donig with SSR.

from found-relay.

1. I'm not sure when the first API server request even happens. It looks like the Fetcher constructors don't call to the server. But I'm digging to see.
2. I got completely stuck on importing CSS where babel just wasn't handling it for server side compilation (which I think is different than rendering). It looked like the only option was to use something like universal-webpack or a css module hook, but the later wouldn't take care of images. So I'm having to take the big bite instead of building up to it.

Edit: I don't see the fetch method ever getting called.

from found-relay.

const relayPayloads = serialize(fetcher, { isJSON: true });

Is returning an empty array in server.js. Is that unexpected?

from found-relay.

My instinct is that the problem is around the last line of output seen in #57 (comment). I say that because context: undefined seems like it could affect an expression like context.location.pathname. I can't think of other expressions that refer to pathname.

from found-relay.

I finally pinned down the expression that is generating the error:

https://github.com/4Catalyzer/found/blob/68ae966a079a75dbb09c49231a68673f1ec5bbf1/src/Matcher.js#L58

In the scope of that function these are the parameter values:

matchLocation: undefined
location: true

Seems off since they both expect to be objects with the property .pathname. Is this an issue with found?

Edit: This method https://github.com/4Catalyzer/found/blob/be1f87738121b30e2b044656b29e1094e2ea26da/src/utils/createStoreRouterObject.js#L22 is getting called with the first two parameters as '/', true.

from found-relay.

Well f* me. I had legacy code from when I was using react-relay-router. There was a component that was using context.router.isActive, which was getting through and failing inside found. 🤦

from found-relay.