Comments (2)
One reason to keep them in the user models is because if you want to overide the fillable property you will need to completely replace all those fields in each model. Whereas if you have them in the user models, it does not matter. You can change them (delete or add one field) or completely delete them if you don't need them.
For instance, your proposed behaviour would be like the following:
class BaseUser extends Eloquent
{
protected $fillable = ['firstName', 'lastName', 'password', 'gender'];
}
class User extends BaseUser
{
protected $fillable = ['firstName', 'lastName', 'password'];
}
If I wanted to add another field to my fillable property, I would need to write all the other fields as well. That isn't convenient at all.
However, if we have those fillable attributes in the User class, it'll be so easy to add a new field to the fillable property.
/** First generated model **/
class User extends BaseUser
{
protected $fillable = ['firstName', 'lastName', 'password'];
}
/** You'll just need to add another field and that's it **/
class User extends BaseUser
{
protected $fillable = ['firstName', 'lastName', 'password', 'gender'];
}
Another reason not to have new fields automatically added to the fillable property is because it can be dangerous. Since all new database fields will be automatically a fillable attribute, you don't get to decide weather you actually want it to be fillable or not. Remember that the reason for having fillable attributes is to defend yourself from mass assignment. If every new field is mass assignable by default, you are potentially creating security vulnerabilities in your system without even being aware of it.
from laravel.
Perhaps an option to enable one feature or another would be fine. The safer one should be the default and putting the fillable property in base models would have to be manually enabled. What do you think? Seems reasonable to me 🤔 And I'm willing to accept this pull request if you would like to contribute :)
from laravel.
Related Issues (20)
- Dates property is deprecated since Laravel 8
- Hidden property not being generated in base Model files
- Seems to struggle with relationships where the source and target column have the same name HOT 2
- Typo in WhoDidIt referring to "udpated_by" instead of "updated_by" HOT 2
- Support for Enums HOT 1
- Model relationships not generated in Laravel 9
- Error when one of the MySQL table on the server have a "." in it's name HOT 1
- HasOneOrMany
- stancl/tenancy how use HOT 2
- Deprecated "dates" property HOT 1
- Datetime or Timestamp fields are mapped to classic date in casts
- Generating models with_property_constants doesn't work correctly
- error HOT 1
- Please delete this HOT 1
- Feature request for Base File to make this package more Advanced
- Add return types to generated relations HOT 1
- Development for sql server support
- Error creating models - Laravel 9.52.6
- Laravel 11 support HOT 10
- Laravel 11 - SQLite Support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel.