`equals` and recursive structures leads to `Maximum call stack size exceeded` about remeda HOT 5 CLOSED

I'd say this is an edge case that is not worth adding more complexity (and runtime cost) for all invocations. I don't mind adding a equals.recursive flavor of equals so that users can opt-in to it, but I don't think it will see much usage.

@TkDodo, wdyt?

from remeda.

I agree. But if we decide that this is "an edge case that is not worth adding more complexity (and runtime cost)", I think the recursive checks can also be removed from PR with mergeDeep.

from remeda.

I generally agree, with the onlh difference being that that is a new function without existing users so new adopters take it as a whole. Fixing equals would mean changing it for existing users

from remeda.

@dartess, is there anything actionable you want to do with this issue? I'm thinking of closing it as it's now findable if anyone else encounters the issue and search our issues so they can find this discussion.

from remeda.

I don't think it's necessary to do something about it if you don't feel like doing something about it. So, just closing.

from remeda.