Problem with `mapValues` types about remeda HOT 6 CLOSED

Looking at this again, I think you might be right! The key could be string | number but that just because you can use a number to index into the object. The mapper itself uses Object.keys() which only returns string keys...

I don't mind reviewing a PR to fix this!

Sorry for the misleading first answer again!

from remeda.

@eranhirsch i got an error with ${keyof T}. But ${Exclude<keyof T, symbol>} looks working and better than keyof T & string. I, too, will think a little more and experiment, after which I will do a PR.

from remeda.

A record would be flattened as { [K in string]: T } for your example, { [key: string]: T } is a different object. This isn't related to remeda, I don't know why keyof for an indexed object returns string | number.

https://www.typescriptlang.org/play?#code/C4TwDgpgBAsiBKEDGB7ATgEygXigbygG0BpKASwDsoBnYNSgcwF0AuKAIgwFcBbHkdlAC+AbgBQoSLBABJChggAPCFlwFCAawgg2tehWZtOvfoNFiJ4aGmToMxbdRxQtIFADNpiVJnEB6PygggD0AfkspSgVFBxAnXFcPaTlolX9AkPCgA

mapValues simply types the key as keyof T, it's doing what it's supposed to do here

from remeda.

Yes but it can be easily fixed in remeda via keyof T & string

from remeda.

I don't know why it's being typed as number, but it means that typescript thinks the key could be a number too, and if anyone is relying on this being the case we would break their assumption and code. If the type should be just string typescript would have inferred that.

from remeda.

So thinking about this some more, it feels like the type for the key should be

`${keyof T}`

It would cover a type like { [index: number]: unknown } properly.

@dartess, wdyt?

from remeda.