Giter VIP home page Giter VIP logo

Comments (4)

remi avatar remi commented on May 26, 2024

Cool, I didn't know you could do that.

But I think using middleware is necessary, because the user doesn’t have access to the Fadaray object. Using request and response middleware, it can add application logic to Her, without touching the lower level code.

from her.

technoweenie avatar technoweenie commented on May 26, 2024

Fair enough. Faraday was designed specifically so you could get
access to it. I never liked how ActiveResource hid all that away,
making it really difficult to debug.

With access to the Faraday adapter, I could inject some basic Faraday
logger middleware to get a dump, without worrying about using a Her
logger middleware.

Just some friendly feedback. I'm hoping to get Faraday to 1.0 this
year. It's our last push to change things internally before
stabilizing the library (for instance, I'd love to support streaming
requests/responses). I look forward to your feedback if you ever run
into Faraday issues.

from her.

remi avatar remi commented on May 26, 2024

That’s a good point actually. If I want Her users to be able to use Faraday at its full potential, the adapter should be publicly available. I’ll look into it.

Thank you for your feedback Rick! Keep up the good work 😄

from her.

remi avatar remi commented on May 26, 2024

FYI, I went with your way of inserting middleware into Her connections (see this section in README). It’s much more simple and powerful to expose the builder object. Thanks again!

from her.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.