Comments (4)
Cool, I didn't know you could do that.
But I think using middleware is necessary, because the user doesn’t have access to the Fadaray
object. Using request and response middleware, it can add application logic to Her, without touching the lower level code.
from her.
Fair enough. Faraday was designed specifically so you could get
access to it. I never liked how ActiveResource hid all that away,
making it really difficult to debug.
With access to the Faraday adapter, I could inject some basic Faraday
logger middleware to get a dump, without worrying about using a Her
logger middleware.
Just some friendly feedback. I'm hoping to get Faraday to 1.0 this
year. It's our last push to change things internally before
stabilizing the library (for instance, I'd love to support streaming
requests/responses). I look forward to your feedback if you ever run
into Faraday issues.
from her.
That’s a good point actually. If I want Her users to be able to use Faraday at its full potential, the adapter should be publicly available. I’ll look into it.
Thank you for your feedback Rick! Keep up the good work
from her.
FYI, I went with your way of inserting middleware into Her connections (see this section in README). It’s much more simple and powerful to expose the builder
object. Thanks again!
from her.
Related Issues (20)
- after_find called twice HOT 1
- path_prefix option is not used when belongs_to association is set. HOT 5
- add ability to wrap "where" clause HOT 4
- Support for first, limit, group and order HOT 6
- Support for update_attributes missing? HOT 6
- Support for association extensions HOT 1
- undefined method `map' for nil:NilClass for association HOT 6
- Class-level response parsing? HOT 1
- Scopes on JsonApi model
- Find or Create by ID HOT 2
- Have we considered making this gem more SEO friendly? HOT 4
- Attributes don't play nicely with ActiveModel::Dirty in Rails 6
- Safe Navigation Operator &. don't works on nil objects
- I would like to have find_by! in order to raise an exception instead of a nil HOT 1
- HashWithIndifferentUsage is slow, and requires large ActiveSupport dependency
- ruby 2.7, rails 6.0 and faraday 1.0 HOT 3
- Release version 1.1.1 HOT 1
- her-rb.org website inaccessible. HOT 1
- Organizing a fork of her HOT 1
- Execute rescue_from plus her? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from her.