Giter VIP home page Giter VIP logo

Comments (9)

brophdawg11 avatar brophdawg11 commented on April 28, 2024 3

This should be fixed with Remix 1.12.0 which should be out in the next hour or two

from blues-stack.

zvin avatar zvin commented on April 28, 2024 1

I don't think that this is the same issue.
It also happens in development.
And even in production a page that doesn't exist should send a 404, not a 500.
The behavior differs from previous remix versions and from running it with remix serve.

from blues-stack.

zvin avatar zvin commented on April 28, 2024

Minimal reproduction here: https://stackblitz.com/edit/node-zxrwpd

from blues-stack.

zvin avatar zvin commented on April 28, 2024

One thing that solves the issue is to remove the eslint --bundle flag here

from blues-stack.

machour avatar machour commented on April 28, 2024

This is an intended behavior in production, see Matt's answer here: remix-run/remix#5115 (comment)

from blues-stack.

zvin avatar zvin commented on April 28, 2024

The issue does not happen when not using eslint's --bundle flag or running server.ts with ts-node directly.

from blues-stack.

brophdawg11 avatar brophdawg11 commented on April 28, 2024

This looks like an issue with the bundling approach causing multiple disparate ErrorResponse classes to exist and this causing internal instanceof ErrorResponse checks to fail. We'll need to change those checks to avoid using instanceof for bundling approaches like this and instead use prop detection

from blues-stack.

brophdawg11 avatar brophdawg11 commented on April 28, 2024

The above merged PR will go in the next react router release, either 6.7.1 or 6.8.0 depending on what is in it. Then Remix will pick that up in it's next release.

from blues-stack.

zvin avatar zvin commented on April 28, 2024

Thanks for the quick fix!

from blues-stack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.