Comments (4)
brookslybrand
commented on May 4, 2024
@majamarijan sorry no one ever got back to you on this
I've been spending some time cleaning up issues and updating the website. Is this still happening for you? I was unable to reproduce
from react-router-website.
majamarijan
commented on May 4, 2024
Hi @brookslybrand! Yes, it is better (Chrome and Firefox), but the issue still exists => when change the theme and then click on the bookmark.
Clicking on the blank space on the page doesn't affect the theme anymore. That's corrected well!
from react-router-website.
brookslybrand
commented on May 4, 2024
@majamarijan, are you toggling your network speed or anything? I'm wondering if the action is getting cancelled before the cookie has a chance to update?
from react-router-website.
majamarijan
commented on May 4, 2024
@brookslybrand , no toggling. Yeah, I think that's the problem. If the theme is changed, and I click on the bookmark in a half a second or less after changing the theme, then this happens. Or, I change the Theme and then double click on the bookmark (like # Tutorial). I do the same on the MDN website and this is not happening (they have the same theme button that opens a dialog).
Yet, it is now much better than before.
from react-router-website.
Related Issues (20)
- Fix www redirections HOT 1
- [Bug]: `useLocation` docs url on vs code redirect to a 404 page HOT 2
- [Bug]: Docs are not working (Something went wrong) HOT 3
- [Docs]: Active links are not indicated on the right navigation section. HOT 1
- It would be nice to know where you are using the side navigation when reading a docs page. HOT 6
- issue with example We have an example for this: https://github.com/remix-run/react-router/tree/dev/examples/auth HOT 2
- [Feature Request]: Add 'Copy' Button to Code Samples in Documentation HOT 3
- Tutorial: confirm in contact.jsx
- Possible security issue: //TARGET_URL/ results in 302 to target HOT 1
- Please add full text search to the documentation HOT 3
- Issue on running in the dev mode using the "npm run dev" script. HOT 1
- [Docs]: Right nav links semi-broken in chrome and edge
- [Docs]: Links on navbar do not work as intended HOT 1
- Replace @ryanflorence/md with custom markdown parser
- Upgrade to Vite plugin
- Add search to the docs HOT 1
- Improve docs navigation
- Add changelog doc
- Fix broken edit link HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router-website.