Comments (4)
I hadn't ever seen it before either but when I looked up how to do module.exports
in the TypeScript docs that's how it said it should be done. AFAICT export =
is the TypeScript equivalent for ESM export default
. In TypeScript, export default
is actually a named export called default
.
from remix.
Ya, just confirmed. If I use export default loader
I get exports.default = loader
in my .js file. But export = loader
gives me module.exports = loader
in the CommonJS output.
from remix.
Any chance the code that requires the loaders could handle this case (kinda like babel's interop require thing):
function _interopRequireDefault(obj) {
return obj && obj.__esModule ? obj : { default: obj };
}
I do this in babel-plugin-macros: https://github.com/kentcdodds/babel-plugin-macros/blob/3263dbe8f9153090249fc2b8dcc4a5c6d61b6625/src/index.js#L84-L88
function interopRequire(path) {
const o = require(path)
return o && o.__esModule && o.default ? o.default : o
}
That works for babel because they set the __esModule
property. TypeScript doesn't do this, so it'd probably be better to go with something like this:
function interopRequire(path) {
const o = require(path)
return typeof o === 'object' && o.default ? o.default : o
}
I think that would be pretty safe and would allow us to avoid the odd syntax.
from remix.
This is no longer relevant
from remix.
Related Issues (20)
- useFetcher return type is `any` since upgrading to remix 2.9.0 HOT 2
- redirect with 307 does not work as expected HOT 5
- install.js.map hook HOT 3
- 2.9.1: useFetcher/useLoaderData types are set to never HOT 8
- Single fetch `response` parameter for loader is undefined if no default export exists in the route HOT 6
- useLoaderData<typeof loader> returns type JsonifyObject<T> rather than T HOT 6
- Single Fetch Issues HOT 8
- Single Fetch: bad behavior in promises that resolve to `undefined` and `null` HOT 2
- Single fetch: loader type us unknown HOT 6
- Single Fetch: missing type for useLoaderData<typeof clientLoader>() HOT 3
- Application crashes on unhandled promise rejection in deferred data HOT 5
- [VitePlugin] HMR breaks with imagetools transformer Vite plugin HOT 1
- Testing utilities have wrong types for meta functions HOT 1
- remix-express/server throws error on IPv6 host or X-Forwarded-Host HOT 3
- `remix dev` fails when workspace has a deprecated node-builtin in unrelated package
- Re: `@remix-run/serve` sets high `max-age` and `immutable` cache header on everything HOT 2
- Action submission triggers a loader re-validation ignoring its `shouldRevalidate` export.
- Single fetch: thrown response stub passed to `handleError`
- Single fetch: allow setting a `nonce` on `StreamTransfer`'s `script` tags HOT 1
- Readonly arrays are not accepted as valid serialisable data in loader HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from remix.