Giter VIP home page Giter VIP logo

Comments (3)

brophdawg11 avatar brophdawg11 commented on May 2, 2024 1

Thank you for the reproduction! This was resolved by #25 and is available in a 0.1.4-pre.0 prerelease currently (I tested that it does indeed fix this reproduction). We should have a 0.1.4 stable out shortly 👍

from v1-compat-utils.

cliffordfajardo avatar cliffordfajardo commented on May 2, 2024

Interestingly, I changed the exports.import value inside of the package.json file of @remix-run/v1-route-convention to use the dist/index.js instead of dist/index.mjs, then ran npm run dev and it worked

CleanShot 2023-10-01 at 13 22 26@2x

I also noticed @jacob-ebey made a PR a few days ago but
CleanShot 2023-10-01 at 13 23 34@2x

it doesnt seem to be published on npm yet since I see the change on the master branch, but when I look at my node_modules folder, I see the old exports content
CleanShot 2023-10-01 at 13 26 44@2x

from v1-compat-utils.

cliffordfajardo avatar cliffordfajardo commented on May 2, 2024

Confirmed locally in the bug repo mentioned above by modifying the package.json of @remix-run/v1-route-convention using the unpublished code + on the codebase at work

// BEFORE:
"exports": {
    "./package.json": "./package.json",
    ".": {
      "types": "./dist/index.d.ts",
      "import": "./dist/index.mjs",
      "require": "./dist/index.js"
    }
  },


// AFTER
  "exports": {
    "./package.json": "./package.json",
    ".": {
      "types": "./dist/index.d.ts",
      "default": "./dist/index.js"
    }
  },

from v1-compat-utils.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.