Comments (4)
I've also added a function which allows the user to check if a given message was sent as part of a separateMessage. This is necessary if the user wants to implement their own on delivery listener, but doesn't want to handle those messages part of separateMessages which are delivered.
from messenger-bot.
@hpincket
Thanks for your contribution, but I have a few concerns:
I am not a javascript developer, but the implementation looks awful.
The main repo is kept in OOP paradigm, meaning that one can create more than one Bot instance.
As you can probably see registering multiple bot instances for your module does not work.
Moreover, I don't see a reason to send multiple messages, maybe for aesthetic purposes?
Also I don't personally think it fits here, but that's just my personal opinion of course so feedback from other devs is appreciated.
from messenger-bot.
@maciekmm
Thanks for the feedback.
As I'm sure you've picked up, I am no javascript developer myself. So I warmly welcome criticisms and suggestions. You're right, this will only work with a single bot, how short-sighted of me! Besides that, would you rather the implementation lie inside of the existing OOP Bot object? I am just trying to understand what a better implementation might look like.
Of course, if you don't see a fit in the repo, the above questions are solely for my improvement.
As far as a use case goes, I wrote a bot which needed to convey a paragraph or two of information to the user. We began with a single message approach, but it was too much. The unapproachable wall of text negated any benefit gained from a conversational UI. The other approach was have the user respond when read for the next part of the message. (Something like "Are you ready to continue?"). This felt too robotic, so we went with separate messages.
from messenger-bot.
This is probably not something we want to implement at this time or with this specific API, I'll therefore close this issue. Thank you for the suggestion and effort put into this issue.
from messenger-bot.
Related Issues (20)
- Your test middleware_post has a bug in it
- Temporary Error
- referral event handler is not working HOT 3
- Trying to get setGetStartedButton working HOT 2
- Undefined Error on like
- Updating Persistent Menu for Platform 1.4 HOT 4
- npm package on package.json HOT 2
- Cannot read property 'forEach' of undefined HOT 2
- Support for messages with (image) attachments
- Greeting Text
- Bot throwing undefined 'forEach' on functions without parsed.entry[0].messaging[0] HOT 1
- built-in NLP support? HOT 2
- getProfile() return undefined HOT 1
- An in-range update of request is breaking the build 🚨 HOT 4
- The package in NPM is not updated HOT 2
- Version 10 of node.js has been released HOT 1
- Getting Cannot read property 'forEach' of undefined HOT 1
- Facebook Graph API 2.6v will be deprecated. HOT 4
- More examples for bots HOT 1
- Insufficient permission to access user profile HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from messenger-bot.