Comments (2)
Could you describe the options that you used? It passes without any assets?
from publish-release.
Sure:
util.promisify(release)({
token,
owner: "cosmos",
repo: "voyager",
tag,
name: `Cosmos Voyager Alpha ${tag} (UNSAFE)`,
notes: `
NOTE: DO NOT ENTER YOUR FUNDRAISER SEED. THIS SOFTWARE HAS NOT BEEN AUDITED.
NEVER ENTER YOUR FUNDRAISER SEED 12 WORDS ONTO AN ONLINE COMPUTER.
Even when we do start supporting fundraiser seeds, don't use it except for
testing or with small amounts. We will release a CLI to use for offline signing
of transactions, and we will also add hardware support for this UI.
Please checkout the [CHANGELOG.md](CHANGELOG.md) for a list of changes.
`,
draft: false,
prerelease: true,
skipAssetsCheck: false,
assets: [
path.join(__dirname, `../builds/Cosmos Voyager-darwin-x64_${tag}.tar.gz`),
path.join(__dirname, `../builds/Cosmos Voyager-linux-x64_${tag}.tar.gz`),
path.join(__dirname, `../builds/Cosmos Voyager-win32-x64_${tag}.zip`)
]
})
It published the release even though the assets weren't where they were supposed to be and missing asset
was reported.
If I were to hazard a quick guess it's because the code should be calling return
after cb
here:
Line 53 in 26df696
from publish-release.
Related Issues (20)
- Error handling bug HOT 1
- Leaks credentials in case of exceptions HOT 6
- Dont use wizzard HOT 6
- Error! The first release should be created manually. HOT 2
- Expected behaviour for second asset upload HOT 5
- This works for windows? HOT 1
- Not publishing release only save as draft HOT 3
- Is possible to pass md file for --notes ?
- Allow to edit release
- Rework reuseRelease option condition
- Create tests
- Can't re-upload on corrupted assets
- Duplicate draft release created when published release with same name exists HOT 3
- Allow the naming of assets
- Overwrite release with the same tag HOT 1
- Fix vulnerabilities : update lodash HOT 3
- Update inquirer
- need help
- Upload hangs with no events emitted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from publish-release.