Droidlysis configuration error about salt-states HOT 5 CLOSED

Hi @gusgravious , you are correct in that the lines you have listed above in the .conf file are the default which come with Droidlysis. The REMnux install of Droidlysis doesn't modify the .conf file for the file locations, but instead modifies the droidconfig.py file. However, with the recent change in their process to move away from global variables and to instead move to a .conf setup, our previous method no longer appears sufficient.

I'll work on fixing the droidlysis state file to account for the new .conf setup going forward.

Thanks for bringing this to our attention!

from salt-states.

Hi @gusgravious , during my reworking of this state, I encountered an error with Droidlysis where the Dex2jar analysis won't run unless it's in verbose mode (issue raised here). Before I raise the new PR to fix the previous issue, I'm going to wait for a day or two to see if this gets fixed so I can continue testing that the changes will work properly. I'll still keep you posted on the progress.

Cheers!

from salt-states.

Great! I did contact the owner of the Droidlysis repo as well, seemed unintentional to include once personal home folder in "general configuration".

Thank you for providing REMnux, it makes my life a lot easier!

from salt-states.

The owner (cryptax) said he was going to be looking at droidlysis today to fix the issue I identified, then I can complete testing and hopefully push a new PR today.

Cheers!

from salt-states.

Sorry for the late reply, I did get feedback from cryptax and just wanted to say thank you for maintaining a fantastic distro and fixing my issue

from salt-states.