Not compatible with gnome 42 about vertical-overview HOT 16 CLOSED

I've made a new release, @duartec3000 there is absolutely no need to donate again 😛 but I appreciate the sentiment.

from vertical-overview.

Ah yeah this has been fixed. The extension is fully compatible with 42. I just haven't published on the gnome website.

from vertical-overview.

I confirm that #101 fixes the issue on Gnome 42 (Debian bookworm). IMHO, it should be merged as soon as possible.

from vertical-overview.

Another issue is that the left and right offset options aren't working as expected. It's difficult to explain in words what's going on, so here's a diagram:

from vertical-overview.

Commit 2127222b breaks the addon - fadeInDesktop() and fadeOutDesktop() are considered deprecated. Removing both functions from the code works fine on my end:

diff --git a/overviewControls.js b/overviewControls.js
index 6b6f6f9..8a3073c 100644
--- a/overviewControls.js
+++ b/overviewControls.js
@@ -335,8 +335,6 @@ var ControlsManagerOverride = {
 
         this._searchController.prepareToEnterOverview();
         this._workspacesDisplay.prepareToEnterOverview();
-        if (!this._workspacesDisplay.activeWorkspaceHasMaximizedWindows())
-            Main.overview.fadeOutDesktop();
 
         this._stateAdjustment.value = ControlsState.HIDDEN;
 
@@ -367,8 +365,6 @@ var ControlsManagerOverride = {
         this._ignoreShowAppsButtonToggle = true;
 
         this._workspacesDisplay.prepareToLeaveOverview();
-        if (!this._workspacesDisplay.activeWorkspaceHasMaximizedWindows())
-            Main.overview.fadeInDesktop();
 
         this._stateAdjustment.ease(ControlsState.HIDDEN, {
             duration: Overview.ANIMATION_TIME,

from vertical-overview.

I confer f8e39b7 does works on Manjaro as of today. A Gnome Shell restart (alt+F2, restart) might be required. This could be added to the instructions.

from vertical-overview.

#101 fixes the specific issue listed above. Gnome 42 might break other things though

from vertical-overview.

I support that request

Just installed it manually from this repo on Ubuntu Jammy develop branch with Gnome 42 and it does not work.

from vertical-overview.

After some times, I've noticed minor issues with workspace zone (I've 2 monitors). On the second monitor, the workspace zone is broken (see screenshot attached) and replaced by a blue dot. I've also noticed that, the first monitor's workspace zone encounters the same issue after a session lock. The first monitor workspace zone can be restored by a shell restart.

from vertical-overview.

@JonathanHolvey for me it seems like this:

from vertical-overview.

Do we have any status on a version getting released @RensAlthuis for Gnome 42 (Ubuntu Jelly LTS)? These horizontal workspaces are diving me up the walls.

EDIT: I can confirm the latest commit f8e39b7 seems to work just fine on Jelly. This should get shipped out ASAP.

~ Joe G.

from vertical-overview.

@RensAlthuis can this be closed because of #101 ?

from vertical-overview.

@RensAlthuis ༼ つ ◕_◕ ༽つ Take all my energy ༼ つ ◕_◕ ༽つ make point release for us plebs, will donate again!

from vertical-overview.

@JonathanHolvey for me it seems like this:
Screenshots

I have the same issue on a 4k screen. The main thing overlaps the thumbnails.

from vertical-overview.

I have the same issue on a 4k screen. The main thing overlaps the thumbnails.

this patch works for me:

--- overviewControls.js	2022-05-25 01:48:30.289432837 +0300
+++ /home/jura/.local/share/gnome-shell/extensions/[email protected]/overviewControls.js	2022-05-23 21:20:38.400741149 +0300
@@ -120,9 +120,8 @@
 }
 
 var ControlsManagerLayoutOverride = {
-    _computeWorkspacesBoxForState(state, workAreaBox, searchHeight, dashHeight, thumbnailsHeight) {
+    _computeWorkspacesBoxForState(state, workAreaBox, startY, searchHeight, leftOffset, rightOffset) {
         const workspaceBox = workAreaBox.copy();
-        const [startX, startY] = workAreaBox.get_origin();
         const [width, height] = workspaceBox.get_size();
         const { spacing } = this;
         const { expandFraction } = this._workspacesThumbnails;
@@ -142,10 +141,10 @@
         case ControlsState.WINDOW_PICKER:
         case ControlsState.APP_GRID:
             workspaceBox.set_origin(
-                this.leftOffset + spacing,
+                leftOffset + spacing,
                 startY + searchHeight + spacing * expandFraction);
             workspaceBox.set_size(
-                width - this.leftOffset - this.rightOffset - (spacing * 2),
+                width - leftOffset - rightOffset - (spacing * 2),
                 height - startY - (searchHeight + spacing * expandFraction) * 2);
             break;
         }

from vertical-overview.

Nice, that patch works for me, too. Can you open a PR?

from vertical-overview.