RFC: Swift Codable Attribute Support about mogenerator HOT 6 OPEN

I can't speak to the Swift devil-in-the-details, but this addition would fit in very well with mogenerator's general thrust of generating obvious code for obvious situations to lubricate Core Data's gears.

from mogenerator.

On vacation atm, so not sure am I missing something obvious...

1. Why the property must be binary..?

2. Approach with Codable looks like proper solution for what I tried to do with CoreDataRepresentable which works with any attribute type

from mogenerator.

Hi @radianttap. It's binary because that's how the built-in coders work and because binary is a type that Core Data understands. JSONEncoder/JSONDecoder and PropertyListEncoder/PropertyListDecoder each convert to/from binary data. It's a good choice to handle any possible Codable, since they can be more complex than the simple enumeration I used as an example. This also parallels how transformables work, which is the behavior I'm aiming for.

from mogenerator.

Commit 28c0a72 includes an implementation of this.

from mogenerator.

Like I said previously, I use CoreDataRepresentable protocol to map custom enums and structs into Core Data supported types. That works rather well in the last year or so.

I never used 'binary' type for the attribute thus when you said it can't be used in predicates it rang a pretty big bell. I went through the largest project I'm maintaining to see just how much I use these attributes in predicates. Ends up – a lot. Most use cases for custom types is to map enums which represent attributes used for filtering. Thus I have a lot of predicates using exactly those types

NSPredicate(format: "%K == %d", Attributes.sportCode, sportCode.coredataValue)

Hence is not an option for me to lose this.

(I'll need to go over other proposed changes in 376, 377)

from mogenerator.

Hey @radianttap, I'm giving CoreDataRepresentable a try and it looks really good, but I think maybe we're mixing up two different but related things. For this issue I'm aiming for a general implementation of Codable. I included an example of an enum because it's a simple, easy to understand example. It may have been a bad choice though, because this issue isn't intended to be specific to enum. It seems like CoreDataRepresntable would be a good idea for better support of enums, but the more general case of Codable properties includes things that may not conform to RawRepresentable and are not enums at all. I think the best approach is probably to use the code in 28c0a72 for this issue but then also look at using CoreDataRepresentable for enum-specific improvements. Does that make sense?

from mogenerator.