Comments (3)
Proposal: Error handling should be unified in the way that each error emits a unified log message of the level error. Additionally there should be e.g. deprecation logs for the old way of configuring datahike. That means using a library like clojure/tools.logging for the logging facade.
from datahike.
for clojurescript support https://github.com/ptaoussanis/timbre might be a good option. what do you think?
from datahike.
I agree and timbre is definitely an option. I used a facade in kabel
before:
https://github.com/replikativ/kabel/blob/master/src/kabel/platform_log.cljc
which allows us to change the logging system later as long as we just need a simple interface. It is not externally changeable, just a flexibility for the kabel developers. This limitation should be easy to overcome, either by multimethods or protocols.
@TimoKramer I would leave this decision to you, if you plan to go ahead. Using timbre directly can also be fine if we feel like maintaining a fork if necessary. I generally try to keep interfaces to external libraries minimal to help portability though. How should the interface in your opinion look like?
from datahike.
Related Issues (20)
- Extend integration-test namespace
- [Bug]: prep-lib is broken HOT 5
- [Bug]: CI token not valid, no release possible
- [Bug]: can't import datahike.api at repl: Unable to resolve symbol: abs HOT 3
- CI: compile and upload native-image binaries to GitHub Releases HOT 2
- Reflection warnings need to be fixed for native Datahike
- [Bug]: datahike.migrate has a problem with schema/double (which cbor converts to float) HOT 2
- [Bug]: unneeded dependencies pulled HOT 7
- Integrate HTTP server HOT 4
- Improve connection handling HOT 1
- [Bug]: NullPointerException trying to transact from CLI HOT 8
- [Bug]: FileNotFoundException over resources/datahike-logo.txt HOT 2
- [Bug]: Inconsistent treatment of invalid constant values HOT 2
- [Bug]: Unable to use Datahike as a git library HOT 2
- [Bug]: `pull-many` query with 3 attr-ids on a range of 500 entities takes ~2,900 ms
- Ability to disable `ensure-stored-config-consistency` HOT 7
- chore: simplify state management
- [Bug]: :config-does-not-match-stored-db for file storage when using VPN HOT 5
- [Bug]: Problem with bump org.babashka/tools-deps-native from 0.1.1 to 0.1.2 and `datahike-logo.txt` not being packaged into the jar
- [Bug]: Metadata is incorrect for various functions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datahike.