Giter VIP home page Giter VIP logo

Comments (8)

replydev avatar replydev commented on May 29, 2024 1

Hi, i also think that a search feature could be useful, this commit d7b4a0c includes a draft.
I want to improve the search UI, but for now let me know your impressions.

Thanks, regards.

from cotp.

replydev avatar replydev commented on May 29, 2024 1

This 7702bd6 is quite better.

from cotp.

replydev avatar replydev commented on May 29, 2024 1

Yeah you are right. 0f8fa30 this could be the final step. Let me know.

Thank you, regards

from cotp.

brian6932 avatar brian6932 commented on May 29, 2024

Nice, I like that esc lets me exit out of the find without exiting out of the whole program.
So my nitpicks would be:

  1. I don't like that when you use find the whole screen gets taken up. If possible, I think it would be nice to put it in a margin/overlay, maybe over the cotp v0.2.0 text, or below the progress bar.

For example, this is how bottom does it:
https://i.nuuls.com/xgp3h.png

  1. This is probably more annoying to do, but while using find, it should instead of only grabbing item on enter, track to closest item you're typing, with like a contains/similarity, and highlight them accordingly as you type. While only actually copying the item on enter. Since esc is already an exit for find, double enter seems unnecessary (as long as there is an overlay/margin like I mentioned in 1.).

from cotp.

brian6932 avatar brian6932 commented on May 29, 2024

Nice, much better. Now there's really only this nitpick:

2. This is probably more annoying to do, but while using find, it should instead of only grabbing item on enter, track to closest item you're typing, with like a contains/similarity, and highlight them accordingly as you type. While only actually copying the item on enter. Since esc is already an exit for find, double enter seems unnecessary.

from cotp.

brian6932 avatar brian6932 commented on May 29, 2024

Perfect!
The only minor nitpick I could have is that the search box should support either, ctrl + w and/or ctrl + backspace, for deleting the whole word

from cotp.

replydev avatar replydev commented on May 29, 2024

The only minor nitpick I could have is that the search box should support either, ctrl + w and/or ctrl + backspace, for deleting the whole word

Done with CTRL-W. Thank you for your advices.

from cotp.

brian6932 avatar brian6932 commented on May 29, 2024

ctrl w/backspace is typically for single word deletion, but this is close enough, Ty for being so receptive ❤️

from cotp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.