Giter VIP home page Giter VIP logo

Comments (3)

cometkim avatar cometkim commented on July 19, 2024

there are three noticeable bugs in the result

  1. Shouldn't the curly brace ({ ... }) be syntax error?
  2. ex`...` impl shouldn't be inlined
  3. and as you reported, wrong encoding

from rescript-compiler.

zth avatar zth commented on July 19, 2024
  1. Shouldn't the curly brace ({ ... }) be syntax error?

No, that's just another block that returns at the end. It's fine.

  1. ex`...` impl shouldn't be inlined
  2. and as you reported, wrong encoding

You can get this to work for external tagged template functions: https://rescript-lang.org/try?version=v11.1.0&code=AIFwhg5hCmAmAq0C2AHANmE0AE0AeWATgHZhq54Bc2AFGIYWAJ4A8AziIQJbEQB8AGmz1GrAPp8AlNgC8fbB269Z2AET5VAKE0BhAPbE2etNAB0aPRBoBvfAANAOAR2AvpM1A

However, right now there's a difference between external (bindings) and internal (written in ReScript) tagged template functions, where externals emit the tagged template syntax, but the internal ones are treated like regular functions. cc @tsnobip

from rescript-compiler.

tsnobip avatar tsnobip commented on July 19, 2024

hmm shoot, this is quite surprising given all strings in rescript should now be in unicode. Given the original PR was quite old, maybe it reused some out-of-date logic around strings.

from rescript-compiler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.