Giter VIP home page Giter VIP logo

Comments (6)

cristianoc avatar cristianoc commented on August 18, 2024 1

Done in #6828

from rescript-compiler.

cristianoc avatar cristianoc commented on August 18, 2024

One observation: the coercion in the example seems to work if the argument type is not polymorphic, e.g. float.
Coercion was not modified for function types, it still uses the original implementation, but the way it's been implemented for variants might interfere with the pre-existing mechanism in certain cases (e.g. polymorphic argument).

from rescript-compiler.

TheSpyder avatar TheSpyder commented on August 18, 2024

Ah, that makes sense. Unfortunately the way I'm trying to use it with Array sort requires polymorphism.

For now I've just used an obj magic.

from rescript-compiler.

cristianoc avatar cristianoc commented on August 18, 2024

@TheSpyder any more tests for #6828 ?

from rescript-compiler.

TheSpyder avatar TheSpyder commented on August 18, 2024

@cristianoc the second example is the one I pulled from my codebase, I haven't come across any others (although I haven't really been looking). I appreciate you looking at this!

from rescript-compiler.

cristianoc avatar cristianoc commented on August 18, 2024

@cristianoc the second example is the one I pulled from my codebase, I haven't come across any others (although I haven't really been looking). I appreciate you looking at this!

Great, that example is covered already.

from rescript-compiler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.