Comments (6)
Done in #6828
from rescript-compiler.
One observation: the coercion in the example seems to work if the argument type is not polymorphic, e.g. float
.
Coercion was not modified for function types, it still uses the original implementation, but the way it's been implemented for variants might interfere with the pre-existing mechanism in certain cases (e.g. polymorphic argument).
from rescript-compiler.
Ah, that makes sense. Unfortunately the way I'm trying to use it with Array sort requires polymorphism.
For now I've just used an obj magic.
from rescript-compiler.
@TheSpyder any more tests for #6828 ?
from rescript-compiler.
@cristianoc the second example is the one I pulled from my codebase, I haven't come across any others (although I haven't really been looking). I appreciate you looking at this!
from rescript-compiler.
@cristianoc the second example is the one I pulled from my codebase, I haven't come across any others (although I haven't really been looking). I appreciate you looking at this!
Great, that example is covered already.
from rescript-compiler.
Related Issues (20)
- Variables with reserved keywords renamed in output, but not reflected in generated typescript HOT 4
- Optimizations lost in uncurried mode HOT 6
- React/JSX broken after external arity handling improvement HOT 8
- Exotic identifiers as field names broken on master HOT 2
- Incorrect print of function under unary operator
- Generating Parsers/Decoders for Types HOT 5
- Comment formatted away in uncurried mode
- v12: comparison emitted but not checked HOT 2
- Polymorphic variant coercion to string: add warning/docs. HOT 4
- RescriptReactRouter crash on master (`window` vs. `$$window`) HOT 8
- pattern matching on polymorphism variant / extensible variant generates inefficient if chains HOT 1
- Uncapitalized cmi path in the error message HOT 2
- v12-alpha: The raise call started recreating exn, which breaks try/catch HOT 6
- Incorrect printing in coercion_module_alias_test.res
- Confusing error message with mismatched optional labeled argument
- RFC: conditional module FFI HOT 15
- genType doesn't check typecheck imports from typescript into rescript HOT 2
- Formatter Breaks Explicit Partial Application Syntax When Split By a Line Break
- Constant folding a pattern match on an unboxed variant produces an incorrect result HOT 1
- Type spread failed on empty variant HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rescript-compiler.