Giter VIP home page Giter VIP logo

Comments (9)

louremipsum avatar louremipsum commented on June 12, 2024 2

Thank you, Gabriel
[email protected] works :) and the server is starting all right, although the image path is not resolved correctly so they are not visible

from react-email.

gabrielmfern avatar gabrielmfern commented on June 12, 2024 1

so the first error is a Windows issue we have already fixed on canary, you can update to [email protected]

the second one though, seems to be something else
I'll checkout your repro when I have some time

from react-email.

louremipsum avatar louremipsum commented on June 12, 2024

Thank you for the quick reply Gabriel :), I will update to the canary version and will tell you the details

from react-email.

gabrielmfern avatar gabrielmfern commented on June 12, 2024

although the image path is not resolved correctly so they are not visible

Where are you placing static files? Also, did you modify the default emails directory? Might be related to #1265

from react-email.

louremipsum avatar louremipsum commented on June 12, 2024

image
this is my current workspace structure

from react-email.

gabrielmfern avatar gabrielmfern commented on June 12, 2024

Try moving your static directory into emails/static

from react-email.

FatahChan avatar FatahChan commented on June 12, 2024

I had the same issue, installing the canary version and moving the static dir to emails/static did resolve the issue.

I am noticing a performance issue, this is my first time using react email, so I am unsure if this is a windows specific or just how it is.

Basically when I am switching between emails it takes at least 1 second to switch, the vercel-invite-user email took at least 3s

I am more than happy to file bug, if it's actually a bug

2024-02-14.06-26-03.mp4

from react-email.

gabrielmfern avatar gabrielmfern commented on June 12, 2024

Hey @FatahChan

I am more than happy to file bug, if it's actually a bug

Not a bug, so no need to file a bug.
But it is something that bothers me, I wish we did have better performance on that. Would be nice to brainstorm
a few ideas on how to tackle this though. Maybe a discussion?

I do know that initial render takes a bit longer because we don't really build the NextJS preview server
so it always re-compiles the preview page which really is not optimal, but not sure if would make a very large
difference.

from react-email.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.