Comments (26)
Please try this version via the "install from zip" option:
https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip
Most stuff should be working, except tags/genres and perhaps the search.
from plugin.video.retrospect.
Branch bug-1718
was created for issue: "SVT Play no listing"
from plugin.video.retrospect.
The api was updated.
from plugin.video.retrospect.
@basrieter
Fix works, thank you.
from plugin.video.retrospect.
In the initial fix I found a few things that didn't work:
-
Categories
-
Genres\tags (mentioned above)
-
Live TV (This is working in version 5.6.4)
-
Öppet arkiv
-
Search (mentioned above)
-
'Currently playing' needs the time before title so we don't trying to play a program in the future. Right now there is 13 'Rapport' in the list. I think it used to be like this: '18:00 - Rapport'
from plugin.video.retrospect.
In the initial fix I found a few things that didn't work:
- Categories
- Genres\tags (mentioned above)
- Live TV (This is working in version 5.6.4)
- Öppet arkiv
- Search (mentioned above)
- 'Currently playing' needs the time before title so we don't trying to play a program in the future. Right now there is 13 'Rapport' in the list. I think it used to be like this: '18:00 - Rapport'
Those are more or less the ones I mentioned in my post.
from plugin.video.retrospect.
Please try https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip again. I think it is all working again: 2 notes:
- The "All Genres/Tags" was removed from their API (can't find it) so the listing is not as long as it was.
- The "Currently playing" thing with the time won't work with the time in front, as it might also be that time day after.
Only thing left is the "Live streams".
from plugin.video.retrospect.
Live streams fixed: https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip
Please verify, as I can't really from the Netherlands.
from plugin.video.retrospect.
I have tested all first level folders and some Categories folders and eveything is working.
I have found a couple of things that could be enhanced.
I think Categories is rather important for the look and feel.
Categories
If you goto Categories and select Drama,
all Singels and TVSeries are missing the image and fanart.
On the next level in TVSeries the image and fanart are shown for the folders (Klipp, Sasong x and Upptäck mer)
The info for this seems to be extracted from the API.
I guess this could also be applied for Genres/tags
Single:
20230911 11:46:55 - [TRACE ] - chn_svt.py - 418 - Single: {'id': '1403983-001', 'name': 'At the Window', '__typename': 'Single', 'urls': {'svtplay': '/video/KZm7rmd/at-the-window', '__typename': 'Urls'}, 'oppetArkiv': False, 'restrictions': {'onlyAvailableInSweden': False, 'onlyAvailableInSwedenFormatted': 'Kan ses i hela världen', '__typename': 'Restrictions'}, 'svtId': 'KZm7rmd', 'videoSvtId': 'jpAdZzp', 'images': {'cleanWide': {'changed': 1686741501, 'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'id': '50073851', 'keyart': False, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'changed': 1686741501, 'id': '50073855', 'keyart': False, '__typename': 'Image'}, '__typename': 'Images'}, 'parent': {'id': '1403983-001', 'name': 'At the Window', 'svtId': 'KZm7rmd', 'images': {'wide': {'changed': 1686741500, 'id': '50073843', 'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', '__typename': 'Image'}, 'cleanWide': {'changed': 1686741501, 'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'id': '50073851', 'keyart': False, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'changed': 1686741501, 'id': '50073855', 'keyart': False, '__typename': 'Image'}, '__typename': 'Images'}, 'urls': {'svtplay': '/video/KZm7rmd/at-the-window', '__typename': 'Urls'}, '__typename': 'Single'}, 'validFrom': '2023-06-30T02:00:00+02:00', 'validFromFormatted': 'Fre 30 jun 02:00', 'duration': 461, 'variants': [{'accessibility': 'Default', 'urls': {'svtplay': '/video/jpAdZzp/at-the-window', '__typename': 'Urls'}, '__typename': 'Variant'}], 'accessibilities': []}
TVSeries:
20230911 11:46:55 - [TRACE ] - chn_svt.py - 418 - TvSeries: {'id': 'eopv56n', 'name': 'Atlantic crossing', '__typename': 'TvSeries', 'urls': {'svtplay': '/atlantic-crossing', '__typename': 'Urls'}, 'oppetArkiv': False, 'restrictions': {'onlyAvailableInSweden': True, 'onlyAvailableInSwedenFormatted': 'Kan bara ses i Sverige', '__typename': 'Restrictions'}, 'svtId': 'eopv56n', 'videoSvtId': 'jnDJZE6', 'images': {'cleanWide': {'changed': 1686136164, 'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'id': '29701314', 'keyart': True, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'changed': 1686136159, 'id': '29756634', 'keyart': True, '__typename': 'Image'}, '__typename': 'Images'}, 'parent': {'id': 'eopv56n', 'name': 'Atlantic crossing', 'svtId': 'eopv56n', 'images': {'wide': {'changed': 1686136164, 'id': '29701314', 'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', '__typename': 'Image'}, 'cleanWide': {'changed': 1686136164, 'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'id': '29701314', 'keyart': True, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'changed': 1686136159, 'id': '29756634', 'keyart': True, '__typename': 'Image'}, '__typename': 'Images'}, 'urls': {'svtplay': '/atlantic-crossing', '__typename': 'Urls'}, '__typename': 'TvSeries'}, 'accessibilities': []}
Currently playing
Currently playing looks like this
In the def create_api_teaser_type(self, result_set):
remark the following:
Row 579
from:
if self.parentItem.metaData.get(self.__filter_subheading, True) and (
"Idag" in sub_heading
or "Ikväll" in sub_heading
or "Igår" in sub_heading
or sub_heading.endswith(" sek")
or sub_heading.endswith(" min")
or sub_heading.endswith(" tim")):
Logger.trace("Ignoring subheading: %s", sub_heading)
new_result_set["name"] = title
to:
# if self.parentItem.metaData.get(self.__filter_subheading, True) and (
# "Idag" in sub_heading
# or "Ikväll" in sub_heading
# or "Igår" in sub_heading
# or sub_heading.endswith(" sek")
# or sub_heading.endswith(" min")
# or sub_heading.endswith(" tim")):
# Logger.trace("Ignoring subheading: %s", sub_heading)
# new_result_set["name"] = title
Now Currently playing looks like this, with info when the show is available.
Live TV
Live TV looks like this
Live TV in version 5.6.4 still works and it looks like this.
In the above all images is fetched from the API even when no show is playing.
Maybe you could add the end time to the latest working and it is fixed.
All is working and this is just enhancement if you got the time.
Greate work! Thanks for all the hard work fixing this to us.
from plugin.video.retrospect.
Thanks for your feedback:
- Currently Playing: Fixed (forgot something)
- Live TV: End times are no longer present in the API. But I managed to get one by reading the next item in the list.
- Live TV: Thumbs are not always present. But most have them.
I will have a look at the artwork in general.
from plugin.video.retrospect.
Please redownload https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip and see if it is better now?
from plugin.video.retrospect.
This is the image from Categories and Drama using Viewtype: Wall
The poster images only seems to work on Movies,
As for Series, text don't fit, text is missing, so you don't allways see the name.
Before you used the format image and there was the name of the shows allways visible.
I guess the image used in TVSeries show folder is the best option.
My guess is that the posters are not ready to use everyware yet.
from plugin.video.retrospect.
Currently Playing and Live TV look perfect and is workig OK
from plugin.video.retrospect.
The thumbs/poster are generated using their own API and the JSON data they send. They apparently cut of text:
https://www.svtstatic.se/image/portrait/1080/36820195/1686132923
from plugin.video.retrospect.
For the thumbs: use image/custom instead of image/portrait
https://www.svtstatic.se/image/custom/430/36820195/1686132923
https://www.svtstatic.se/image/custom/720/36820195/1686132923
https://www.svtstatic.se/image/custom/1080/36820195/1686132923
from plugin.video.retrospect.
For the thumbs: use image/custom instead of image/portrait
https://www.svtstatic.se/image/custom/430/36820195/1686132923 https://www.svtstatic.se/image/custom/720/36820195/1686132923 https://www.svtstatic.se/image/custom/1080/36820195/1686132923
But then they won't be "portrait" format and Kodi will "squeeze" them:
from plugin.video.retrospect.
This is what a poster should be:
from plugin.video.retrospect.
Posters (portraits) in previously Retrospect were never used in SVT Play.
Now Posters are used everywhere with the fix and it shows croped images, part of the text on images and images without text. It's not ready for using Poster everywhere.
When listing all the Category / Series on the website it uses the custom image
https://www.svtplay.se/kategori/serier?tab=all
When listing the TVshow, the foldes 'Säsong', 'Klipp' and 'Upptäck' mer uses the custom image
https://www.svtplay.se/atlantic-crossing
After the [Fixed: SVT artwork.] was applied it seems that everything changed from 'Thumbs = Images' to 'Thumbs = Posters' everywhere.
I think you should remove the fix and get back to use 'Thumbs = Images' for everything as before and just fix 'Thumbs = Images' for Categories and Genre/tags.
from plugin.video.retrospect.
I have gone back and dowloaded the version up to the fix:
Changed: SVT Live and Currently Playing tweaks.
I have tested this version and everything is working as before the API changes.
It looks perfect except for one thing as mentioned.
- Open 'Categories' and goto 'Drama'.
- See the images used for the folder 'Drama'
- Open 'Drama' folder
Both Singles items and TVSeries Folders is using the parent info from 'Drama'.
The foldes below this is working OK.
The only thing needs to be fixed is that Singels and TVSeries should be using Singles items image and TVSeries Folders image and not use the parent 'Drama' images,
If not possibe to fix this I think this is far better to released this and not the changes with using Posters.
from plugin.video.retrospect.
So basically: no posters, just thumbs?
from plugin.video.retrospect.
Please try: https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip again.
from plugin.video.retrospect.
Great work. Everyting looks fanatastic with the images now!
I did find that the Search gives an error.
Retrospect-log: https://paste.kodi.tv/dolafipero.kodi
from plugin.video.retrospect.
Great work. Everyting looks fanatastic with the images now!
I did find that the Search gives an error. Retrospect-log: https://paste.kodi.tv/dolafipero.kodi
What did you search for?
from plugin.video.retrospect.
chn_class.py - 502 - Searching for 'abba'
I did a search on 'Lokala' and that works.
from plugin.video.retrospect.
I guess it has to do with 'onlyAvailableInSweden'
See the above log:
folderaction.py - 133 - + KeyError: 'restrictions'
from plugin.video.retrospect.
When i click "Recent" the description is missing, seems it's using the heading instead?
See 3 screenshots below that illustrates what i mean:
And
And
from plugin.video.retrospect.
Related Issues (20)
- SVTPlay missing description on Recent HOT 18
- Betere favorieten titel bij :Alle afleveringen: folder
- RTL XL is gestopt. Uitzendingen staan nu op Videoland. HOT 55
- Retrospect onder versie Kodi19.5 kan ik niet laden vanuit repository HOT 13
- Een vernieuwd NPOStart HOT 2
- tv4play premium with sports HOT 1
- all channels gone? HOT 13
- NPO werkt niet meer HOT 144
- Youtube add-on dependency HOT 2
- Retrospect 5.72 not working HOT 25
- NPO ondertitels zijn kapot HOT 7
- Letters met een umlaut incorrect in de NPO start ondertiteling HOT 2
- RTL XL all listing is gone HOT 1
- lijst in "recent" voor "vandaag" in NPO is niet compleet HOT 35
- afspelen programma stopt niet HOT 2
- NPO Start streams do not play anymore HOT 6
- PVR stopped working due to API change
- Wrong metadata after second play HOT 9
- Missing ip in the url in the web dialog for TV4 Play HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plugin.video.retrospect.