SVTPlay missing description on Recent about plugin.video.retrospect HOT 18 CLOSED

I added the badge and descriptions (not yet live stuff). Please check: https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1719.zip

from plugin.video.retrospect.

I added the live indicator: https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1719.zip

from plugin.video.retrospect.

Branch bug-1719 was created for issue: "SVTPlay missing description on Recent"

• Url: https://github.com/retrospect-addon/plugin.video.retrospect/tree/bug-1719

from plugin.video.retrospect.

Please download https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1719.zip and see if it fixes the issue.

from plugin.video.retrospect.

Thanks for the quick response.
Have downloaded bug-1719.zip.
Description has returned to items under Categories, however not on Recent
which is the main gateway for me using the addon.
It worked on the old api.

from plugin.video.retrospect.

I have descriptions, but they are the same as the title.....but that is what the API gives me. So can't fix that:

from plugin.video.retrospect.

Thanks for trying.
Getting the description for Categories was a big improvement anyway, thanks.

from plugin.video.retrospect.

I will create an update soon.

from plugin.video.retrospect.

The changes you made did the work. Now it picks up the wide thumbs and fanart with the text same as in the old API. Thanks for that.

I have looked into missing of the description and some more things like LIVE in Currently playing a.s.o.
Here is some test code I came up with. Both must be addend to get the result as in below pictures.

Row 657 After:
            self.__set_expire_time(valid_to, item)

Insert:
        live_just_now = result_set.get('longDescription')
        if 'Live just nu' in live_just_now:
            item.name = "{} [COLOR gold](LIVE)[/COLOR]".format(item.name)

Row 583 Replace:
        if "longDescription" not in new_result_set:
            new_result_set["longDescription"] = result_set.get("description")

With:
        if "longDescription" not in new_result_set:
            badge = result_set.get("badge")
            if badge is None:
                new_result_set["longDescription"] = result_set['images']['wide']['description']
            else:
                new_result_set["longDescription"] = "[COLOR gold]{}[/COLOR][CR][CR]{}".format(result_set.get("badge", {}).get("altText", None),result_set['images']['wide']['description'])

Currently playing:

Last chance:

Recent:

Series:

from plugin.video.retrospect.

Awesome, thanks @matsarv & @basrieter for the description!

from plugin.video.retrospect.

The description works perfectly now!

from plugin.video.retrospect.

Great! Let me add the live stuff too.

from plugin.video.retrospect.

I am very happy with the description added to Recent/Senaste but there seems to be 2 different descriptions, one short and one long.
Example below shows the same movie accessed from Recent followed by Categories=>Filmer, see the 3 screenshots below that illustrates the difference.
If it can be fixed great, if not then that's fine to and thanks for the effort fixing it in the first place 👍

And

And

from plugin.video.retrospect.

I understand the issue, however: that full description is just not present in the recent API! Sorry!

from plugin.video.retrospect.

Working! (live) is shown as before.

from plugin.video.retrospect.

Great! I will create a release tomorrow.

from plugin.video.retrospect.

I see you haven't merge this issue into the master yet.
After used it for some time I've noticed that 'Currently playing' have duplicated info in the description so I removed it. I've also added the play time into the program title.

Before:

After:

If you got the time, consider make theese changes. If not, it's not essential for the functions.

Row 563
from:
        new_result_set = result_set["item"]
to:
        new_result_set = result_set["item"]
        duration_formatted = result_set.get("durationFormatted")

Row 569
from:
            new_result_set["name"] = "{} - {}".format(title, sub_heading)
to:
            if ("Idag" in sub_heading 
                or "Ikväll" in sub_heading 
                or "Imorgon" in sub_heading):
                sub_heading_time = sub_heading.split(" ")[1]
                sub_heading_day = sub_heading.split(" ")[0]
                new_result_set["name"] = "{} - {} - {} {}".format(sub_heading_time,title,sub_heading_day,duration_formatted)
            else:
                new_result_set["name"] = "{} - {}".format(title,sub_heading)

Remarked ( not in use anymore? )

            # See if we need to filter out some of the headings? Defaults to True
            # if self.parentItem.metaData.get(self.__filter_subheading, True) and (
            #         "Idag" in sub_heading
            #         or "Ikväll" in sub_heading
            #         or "Igår" in sub_heading
            #         or sub_heading.endswith(" sek")
            #         or sub_heading.endswith(" min")
            #         or sub_heading.endswith(" tim")):
            #     Logger.trace("Ignoring subheading: %s", sub_heading)
            #     new_result_set["name"] = title

Row 597:
from:
            new_result_set["longDescription"] = description

to:
            new_result_set["longDescription"] = description

        if bool(sub_heading):
            if badge:
                new_result_set["longDescription"] = f"[COLOR gold]{badge}[/COLOR]"

from plugin.video.retrospect.

I see you haven't merge this issue into the master yet. After used it for some time I've noticed that 'Currently playing' have duplicated info in the description so I removed it. I've also added the play time into the program title.

Before:

[image]

After:

[image]

If you got the time, consider make theese changes. If not, it's not essential for the functions.

Testcode for 'Currently playing'

Skipp this proposal. It seems to have affects in other areas.

from plugin.video.retrospect.