The git hub action for downloading and running review dog on a repo is broken at the m

Other projects are affected too: <a href="https://github.com/orgs/community/discus

Looking at the reviewdog install , it looks like it tries to make a request kind

Yeah, its as if the latest tag disappeared: <p di

Any estimates when the fix will be available? <p dir="a

Github action that installs review dog is failing about reviewdog HOT 12 CLOSED

jsungg commented on June 2, 2024 40

Github action that installs review dog is failing

from reviewdog.

Comments (12)

simonlehmann commented on June 2, 2024 14

Looks like GitHub were able to revert their offending API change - should be working again now.

from reviewdog.

cj commented on June 2, 2024 12

It does look like they released a silent update that ignores headers for https://github.com/reviewdog/reviewdog/releases/latest, but you can call https://api.github.com/repos/reviewdog/reviewdog/releases/latest instead and get the JSON response.

from reviewdog.

mschfh commented on June 2, 2024 3

Other projects are affected too:
https://github.com/orgs/community/discussions/45590

from reviewdog.

pdeslaur commented on June 2, 2024 2

I don't think the issue is related to latest disappearing. Latest appears to be a GitHub semantic that always resolves to the latest release. We can successfully navigate to the latest release for reviewdog: https://github.com/reviewdog/reviewdog/releases/latest

I wonder if GitHub has released a change that ignores the Accept:application/json header for requests to https://github.com. The script may need to be updated to use the API endpoint directly, e.g. https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#get-the-latest-release

from reviewdog.

kfoxb commented on June 2, 2024 1

Looking at the reviewdog install script, it looks like it tries to make a request kind of like this (depending on if you specify a tag, wget may also be used):

curl -w '%{http_code}' -sL -H "Accept:application/json" -o ./tmp.html 'https://github.com/reviewdog/reviewdog/releases/v0.14.1'

Running that command locally for me though returns html and not json. I think that's why we're seeing this line in your output:

2023-01-27T23:16:28.9464292Z �[0m�[91mreviewdog/reviewdog info found version:  <!DOCTYPE html> <html lang= for  <!DOCTYPE html> <html lang=/Linux/x86_64

Not sure why the accept header isn't working though.

from reviewdog.

radzio commented on June 2, 2024 1

Any estimates when the fix will be available?

from reviewdog.

hisuwh commented on June 2, 2024 1

I'm seeing this failing again, though the cause might be different:

::group::🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
  reviewdog/reviewdog info checking GitHub for tag 'v0.14.1'
  reviewdog/reviewdog info found version: 0.14.1 for v0.14.1/Linux/x86_64
  reviewdog/reviewdog info installed /tmp/tmp.BakvtHCtrY/reviewdog
  ::endgroup::
::group:: Running `npm install` to install eslint ...
 Running `npm install` to install eslint ...
  
  up to date, audited 1927 packages in 7s
  
  201 packages are looking for funding
    run `npm fund` for details
  
  3 high severity vulnerabilities
  
  To address all issues (including breaking changes), run:
    npm audit fix --force
  
  Run `npm audit` for details.
  ::endgroup::
/home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 20: Unknown: not found
eslint version:
::group:: Running eslint with reviewdog 🐶 ...
 Running eslint with reviewdog 🐶 ...
  /home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 23: Unknown: not found
  reviewdog: parse error: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token 
  ::endgroup::
Error: Process completed with exit code 1.

from reviewdog.

javierjulio commented on June 2, 2024 1

This issue can be closed out

from reviewdog.

adrianosela commented on June 2, 2024

Yeah, its as if the latest tag disappeared:

Or are y'all seeing issues for pinned versions as well?

2023-01-27T23:34:12.0257709Z ##[group]🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
2023-01-27T23:34:12.0258892Z finding a release for latest
2023-01-27T23:34:12.7452370Z ##[endgroup]
2023-01-27T23:34:12.7510550Z ##[error]Error: unable to find 'latest' - use 'latest' or see https://github.com/reviewdog/reviewdog/releases for details

which in the install script here https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh corresponds to L90-93.

 90   if test -z "$REALTAG"; then
 91     log_crit "unable to find '${TAG}' - use 'latest' or see https://github.com/${PREFIX}/releases for details"
 92     exit 1
 93   fi

from reviewdog.

ant0nm commented on June 2, 2024

Any estimates when the fix will be available?

Same Q here. When to expect a fix for this?

from reviewdog.

hisuwh commented on June 2, 2024

I think my issue is actually related to: reviewdog/action-eslint#152

from reviewdog.

carmanchris31 commented on June 2, 2024

I agree, this has long since been resolved. 👍

from reviewdog.

Github action that installs review dog is failing about reviewdog HOT 12 CLOSED

Comments (12)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent