Comments (5)
I've been seeing the same thing, the output logs show errors but it doesn't exit 1. It doesn't even report the error to GitHub. It doesn't seem to be very consistent.
from reviewdog.
I had the same issue, so I decided to run vale
manually. Here's my workaround steps:
- name: Get latest version of Vale
id: lastversion
uses: dvershinin/[email protected]
with:
repository: errata-ai/vale
- name: Install Vale
run: |
wget https://github.com/errata-ai/vale/releases/download/v${{ steps.lastversion.outputs.last_version }}/vale_${{ steps.lastversion.outputs.last_version }}_Linux_64-bit.tar.gz -O vale.tar.gz
tar -xvzf vale.tar.gz vale
rm vale.tar.gz
- name: Validate the syntax
run: ./vale --config=.vale.ini *.md
The vale
command has the proper exit code, so the workflow will fail or succeed normally.
You can skip the first step, and wget
the direct link if you want to use a specific version, instead of using the latest.
from reviewdog.
Here's an example of how one format reports failure, the other doesn't:
Run with eslint output format:
/path/to/file
14:3 error Delete `··` prettier/prettier
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
14:3 error Delete `··` prettier/prettier
reviewdog: input data has violations
ERROR: "lint:graphql" exited with 1.
Run with rdjson format:
{"source":{"name":"eslint","url":"https://eslint.org/"},"diagnostics":[{"message":"Delete `··`","location":{"path":"/home/dobes/projects/formative/app.fixups/packages/main/src/ui/client/teamMember/commandCenter/sections/ManageOneRosters/ManageOneRoster.graphql","range":{"start":{"line":14,"column":3},"end":{"line":14,"column":5}}},"severity":"ERROR","code":{"value":"prettier/prettier","url":"https://github.com/prettier/eslint-plugin-prettier#options"},"original_output":"{\"ruleId\":\"prettier/prettier\",\"severity\":2,\"message\":\"Delete `··`\",\"line\":14,\"column\":3,\"nodeType\":null,\"messageId\":\"delete\",\"endLine\":14,\"endColumn\":5,\"fix\":{\"range\":[220,222],\"text\":\"\"}}","suggestions":[{"range":{"start":{"line":14,"column":3},"end":{"line":14,"column":5}},"text":""}]}]}
ERROR: "lint:graphql" exited with 1.
from reviewdog.
Actually, I think my comments above are inaccurate. I wasn't passing -format rdjson
in those cases, so it wasn't parsing the linter output.
from reviewdog.
Facing the same issue, using errata-ai/vale-action@reviewdog
version 3.4.1
with reviewdog version 0.17.0
.
from reviewdog.
Related Issues (20)
- 'github-pr-review' reporter is not making suggestion for blank line addition
- Support for Vale text linter HOT 2
- Bundle related suggestions together
- [BUG] Sarif format not working HOT 9
- fail to run reviewdog: XML syntax error on line 10: expected attribute name in element HOT 1
- 'reviewdog: .git exist but is not a directory' in submodule
- Add support for Azure Devops
- I want to konw which LLM do you uesd HOT 4
- File filter for github doesn't correctly submit comments HOT 3
- Wrong line number is sent to Bitbucket Server Code Insight Reports HOT 2
- Feature Request: Option to Disable the `"reported by reviewdog 🐶"` Prefix in Review Messages HOT 11
- New GitHub Action: terraform-validate HOT 2
- gitlab-mr-discussion fail to get diff HOT 3
- [BUG] breaks if file path contains parenthesis
- There was a lint problem running locally, but when I ran reviewdog on CI, there was no comment output HOT 1
- Logo Visibility Issue in GitHub Dark Theme
- GitHub Pull Request diff API responds with 406 — diff too large HOT 18
- github-pr-review reporter: Marks review threads as resolved if that are resolved
- ESLint - Reviewdog output missing file names
- Reviewdog reports issues in old lines instead of new ones
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviewdog.