Comments (15)
@Saljack both works for me. Can you verify the issue please ?
from nb-darcula.
Steps to reproduce on Mac:
- Go to class
- Click somewhere in class file, must be directly inside class, not in a method call/constructor
- CTRL + i (insert code)
- Select override and Implement method / Insert Getters and Setters
- Select something press enter
- Nothing happens.
Its worth noting that in the screenshot by @Saljack clearly has a focus set on the 'Find' button while my screenshot does not but also doesn't work, even though the Ok button is clearly supposed to be selected.
from nb-darcula.
If I use Windows LAF everything works ok. So my scenario is:
- Press Alt + Insert (Insert code)
- Select Getter and Setter
- Select some field with space
- Press Enter
- Nothing happen (expected insert generated setter and getter methods)
There are screenshot from insert dialog:
from nb-darcula.
So the default-button behavior does not work using this LAF.
@Revivius: Can you please rename this issue accordingly
Producible for me
Product Version: NetBeans IDE 8.1 (Build 201510222201)
Java: 1.8.0_71; Java HotSpot(TM) 64-Bit Server VM 25.71-b15
Runtime: Java(TM) SE Runtime Environment 1.8.0_71-b15
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
from nb-darcula.
@Revivius: https://tips4java.wordpress.com/2008/10/25/enter-key-and-button/
from nb-darcula.
@Revivius: Also have a look at the sources of https://github.com/JetBrains/intellij-community/tree/master/platform/platform-impl/src/com/intellij/ide/ui/laf Perhaps the guys at JB fixed such an issue?
from nb-darcula.
@markiewb setting "Button.defaultButtonFollowsFocus" to TRUE did not help, may be related to:
https://netbeans.org/bugzilla/show_bug.cgi?id=149102
This is the last issue I want to address in v1.4.
from nb-darcula.
@Revivius: Yes. I also tried it out and it did not work. Perhaps the LAF alters the "inputMap"/"actionInputMap" of JPanels/JTrees?
JTrees, because in all the screenshot there are trees, which do not delegate the ENTER-key.
from nb-darcula.
@markiewb I tried to use BasicTreeUI and MetalTreeUI instead of DarculaTreeUI but no change. I cant see anything that modifies input map of JTrees also. Here it is:
https://github.com/bulenkov/Darcula/blob/master/src/com/bulenkov/darcula/DarculaLaf.java#L354-L358
from nb-darcula.
@Saljack thank you for reporting and @dylanvorster for clarifying.
and @markiewb thank you once more for pointing me to right direction. With this fixed I think we are ready for v1.4.
from nb-darcula.
f9ece35#diff-9fbfce4e959f187cc27903ee921c1824L441
Why did you remove the invertIcon-feature from #41 ? Accidentally? maybeEnableIconFilter
was introduced, but never used - at least in that commit!
from nb-darcula.
@markiewb it was an accidentall commit and i have corrected it. Last commit uses maybeEnableIconFilter.
from nb-darcula.
@Revivius: Ok, yes you are correct. I found it aa46792#diff-9fbfce4e959f187cc27903ee921c1824R446
from nb-darcula.
Cool. It really works. Tested with toString/getter/setter code generator.
from nb-darcula.
Good to know!
from nb-darcula.
Related Issues (20)
- How to add to a non-maven Netbeans RCP application
- Please create tags/releases
- Color contrast of Java icon in Options menu
- Replace Icons with IntelliJ Darcula Icons
- Markdow files are not so readable
- jsp:include code completion popup hard to read
- New Widget selection Glow under Java 11
- Issues about syntax coloring & window's color
- NetBeans 9.0 compatibility HOT 1
- Same background color for files from the same project are too similar
- HiDPI icons in tabcontrol and openide.awt modules HOT 1
- What about to Donate the SourceCode to Apache NetBeans HOT 17
- Any reason to use the AlexFalappa JAR? HOT 4
- Warnings in NB 10.0 using openjdk 11 HOT 3
- Inconsistence between code completition font color HOT 9
- NBM on Maven Central? HOT 2
- GUI Builder Colors HOT 2
- Manual install option/github releases HOT 5
- unreadable numbers in performance graph
- darcula HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nb-darcula.