Comments (13)
Someone has already logged this as an RFE on NetBeans: https://netbeans.org/bugzilla/show_bug.cgi?id=246199.
As far as I can tell the problem will solve itself - also in nb-dracula - when this code change is released.
from nb-darcula.
@phansson you are right; core.ui in NB 8.1 still has the hardcoded BLUE color and changing the "u" and "a" style colors as described in nbdev mailing list does not solve the problem, so we will have to wait until fix is released. Though I have problem understanding the dates in the NetBeans Bugzilla. Fix seems to be merged at 2015-09-13 into main-silver and NetBeans NB 8.1 was released in 2015-11-04 according to NetBeans release history, so I think it should already have been there. What am I missing ?
from nb-darcula.
@phansson please vote for this issue for other hardcoded colors:
https://netbeans.org/bugzilla/show_bug.cgi?id=257675
Thank you!
from nb-darcula.
@Revivius: Ask [email protected] (the dev, who applied the change)! Perhaps the version of the modules hasn't be changed and thus an old module has been included in NB8.1
I filed https://netbeans.org/bugzilla/show_bug.cgi?id=257823 and will ask Jirka for a change. Perhaps it can be still included in the upcoming 8.1patch1?!
from nb-darcula.
@markiewb voted!
Do you think https://netbeans.org/bugzilla/show_bug.cgi?id=257675 will make it to 8.1patch1 ? Or it is too late for the patch?
from nb-darcula.
@Revivius: I wrote an email to Jirka regarding #257823. Lets wait for the answer
Regarding: https://netbeans.org/bugzilla/show_bug.cgi?id=257675 I doubt it. Provide a patch for the issue and then contact Geertjan Wielenga (the enthusiastic NB product manager, who wrote already two blog entries about the plugin). Perhaps then it can be included in Patch2 or later
from nb-darcula.
@Revivius: BTW there are still 3 good pull requests to be merged!
from nb-darcula.
@markiewb as just commented on the mailing list, check the original patch from that issue vs what was actually committed. The patch might have fixed the issue, what was committed wouldn't. The "fix" is probably already in there! 😄
from nb-darcula.
@neilcsmith-net, @markiewb there are two NotificationImpl classes. Please see my post on dev mailing list:
http://forums.netbeans.org/viewtopic.php?p=168760#168760
from nb-darcula.
Fixed in NB8.2
https://netbeans.org/bugzilla/show_bug.cgi?id=257675#c5
https://netbeans.org/bugzilla/show_bug.cgi?id=246199#c8
from nb-darcula.
@markiewb; thank you for fixing
https://netbeans.org/bugzilla/show_bug.cgi?id=257675#c5
I checked your fixes in NB 8.2 and they are all great except:
from nb-darcula.
Fixed by @markiewb in NetBeans 8.2:
https://netbeans.org/bugzilla/show_bug.cgi?id=246199#c8
Thank you @markiewb for making NB look better in dark LAFs.
from nb-darcula.
I checked your fixes in NB 8.2 and they are all great except:
Filed https://netbeans.org/bugzilla/show_bug.cgi?id=268544 and fixed in the dev version.
from nb-darcula.
Related Issues (20)
- How to add to a non-maven Netbeans RCP application
- Please create tags/releases
- Color contrast of Java icon in Options menu
- Replace Icons with IntelliJ Darcula Icons
- Markdow files are not so readable
- jsp:include code completion popup hard to read
- New Widget selection Glow under Java 11
- Issues about syntax coloring & window's color
- NetBeans 9.0 compatibility HOT 1
- Same background color for files from the same project are too similar
- HiDPI icons in tabcontrol and openide.awt modules HOT 1
- What about to Donate the SourceCode to Apache NetBeans HOT 17
- Any reason to use the AlexFalappa JAR? HOT 4
- Warnings in NB 10.0 using openjdk 11 HOT 3
- Inconsistence between code completition font color HOT 9
- NBM on Maven Central? HOT 2
- GUI Builder Colors HOT 2
- Manual install option/github releases HOT 5
- unreadable numbers in performance graph
- darcula HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nb-darcula.