Project updates about django-health-check HOT 6 CLOSED

@aleksihakli thanks I've seen your PR and left a comment. Please split those things as much as possible. That way we can merge them faster.

from django-health-check.

@codingjoe Hey Joe. I've split the pull requests into 4 smaller PRs, #64, #65, #66 and #67. The logging change, #64, is necessary for cleaner and more concise logging and error handling in the project and I will contribute another set of changes to improve the existing backends if that change gets accepted.

from django-health-check.

I haven't looked into the logging PR yet, but I will. You can also check out the MajorRefactoring PR. I did make a lot of changes there, but never found the time to split them into smaller chunks and to merge them.
Maybe you find something interesting in there.

What I currently very much dislike this that some methods return Exceptions.... They should be raised, not returned. Similar to how Validators work in Django.

from django-health-check.

Hey,

I actually saw at least two return statements which are fixed in the S3BotoStorage patch. I'll take a look at the major refactoring patchset and see if it could be rebased into smaller chunks on top of master too.

I'll be contributing some tests later on for a bit more comprehensive coverage.

EDIT: Return behaviour corrected to Raise in here: https://github.com/KristianOellegaard/django-health-check/pull/67/files

from django-health-check.

@aleksihakli yeah, the smaller the better and tests if possible. That is the biggest issue really. There are no tests :/

from django-health-check.

All changes merged in the original proposal, so closed.

from django-health-check.