Comments (7)
Just found this little thing - trying to built with that in main manifest file.
<uses-feature android:name="android.hardware.nfc" android:required="false" />
from react-native-nfc-manager.
Hi @troelsh , really thanks for spotting this issue!
I will modify the AndroidManifest.xml
based on this soon~
from react-native-nfc-manager.
@whitedogg13 sounds great!
I will test it
from react-native-nfc-manager.
@whitedogg13 but this reversely will not work for app's that demands NFC functionality and only want NFC devices to see the app.
Maybe this setting should be removed from the modules manifest and added as an instruction on how to set it up in the main manifest file of the app?
from react-native-nfc-manager.
Hi, @troelsh thanks for the insight.
Regarding this topic, I think setting the requirement level to false
is a fair option. The main reason for that is because NFC is used as a supplementary feature for most apps.
Ultimately I think how to set this flag depends on the nature of the library. For example, I have checked another project I have contribute to (react-native-ble-manager), and in that project the hardware requiremen has been set to true
. I think that's because BLE is mostly used as a mandatory feature.
On the other hand, I think clarifying this point in documentation is definitely a good idea. Do you want to propose a PR for that? I'll be happy to merge it! :)
BTW, I have just added a small feature to detect NFC support by rejecting promise in NfcManager.start
call in the latest version, this might affect your app if you're not handle promise rejection previously. Just for your reference.
Thanks!
from react-native-nfc-manager.
@whitedogg13 i tried my best to make a suitable description that explains this. See PR #17
I just found the "bug" i will let my dev colleague who has integrated your module know to handle promise rejections if he doesn't do that already. 👍
from react-native-nfc-manager.
We now have set default hardware permission to false and PR #17 merged. Thanks @troelsh
from react-native-nfc-manager.
Related Issues (20)
- Build Failed after install react-native-nfc-manager - json.put("canMakeReadOnly", JSONObject.NULL) HOT 1
- Mifare-SmartMX/Plus support planned? HOT 2
- Expo EAS Local Build fails (not expo run:ios) HOT 1
- NDEF is missing in the entitlement HOT 1
- Tag IDs returned big-endian on iOS and little-endian on Android HOT 2
- Very poor documentation HOT 4
- How to add password protection to NTAG216 HOT 2
- tag.ndefMessage is undefined HOT 3
- Does your library support ISO 7816 or ISO 14443 A standards?
- Does your library support ISO 7816 or ISO 14443 A standards?
- Add ability to to selecting PollingOption on IOS HOT 1
- Unable to write HOT 2
- Get tag UID before Write action HOT 2
- NFC not working on IOS after clicking to quickly HOT 2
- Update dependency version for @expo/config-plugins HOT 4
- NFC device to device HOT 2
- Problem with iso15693_readMultipleBlocks command HOT 2
- How can I format an NFCTag of typeV from NDEF.formatable to NDEF in iOS? HOT 2
- Expo v50 HOT 1
- crash in android using NfcManager.isEnabled() HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-nfc-manager.