Not all errors are caught when processing requests about restrserve HOT 2 CLOSED

I think the issue is here:

It's checking

inherits(x, "simpleError")

But if you look at base errors vs. errors that come from rlang:

try_capture_stack <- RestRserve:::try_capture_stack
class(try_capture_stack(stop("test")))
# [1] "simpleError" "error"       "condition"
class(try_capture_stack(rlang::abort("test")))
# [1] "rlang_error" "error"       "condition"

Is there any reason that we couldn't change that line to be either:

inherits(x, "error")

or

inherits(x, c("simpleError", "rlang_error"))

from restrserve.

I think inherits(x, "error") should be good enough. Not sure why rlang decided to omit simpleError class.
Thanks for investigation! Would you be able a bmot a PR?

from restrserve.