Bookmark node - sticky keys about rgthree-comfy HOT 7 CLOSED

I was using Safari yes. I have just replicated on Chrome and Firefox as well, the same behaviour happens.

from rgthree-comfy.

Interesting, I can see why CMD + C and CMD + V would stick. But I can't find a reason why CMD + Enter would, other than Mac just always not sending a keydown if CMD is pressed. Not impossible, I suppose.

I added a handler so if the META/COMMAND key is lifted (which is working), then rgthree-comfy will clear any other keys that may be stuck. Since I don't have a Mac, let me know how this works.

from rgthree-comfy.

It seems to work just fine! Thank you!

from rgthree-comfy.

Thanks for opening this up. Are you using Safari? Can you also try on Chromium and/or FireFox.

The details here are that the browser window must be losing focus and/or comfyui is swallowing the event such that rgthree-comfy never receives a signal the key has been lifted (unfortunately, browsers don’t have a check for ‘is this key currently down’ but need to track state through a manual ‘key is pressed’ and ‘key is released’; but if that second signal is never sent then the program would forever think the key is still pressed).

from rgthree-comfy.

If you alt-tab out and back and then set the bookmark does it work properly?

from rgthree-comfy.

I'm unable to reproduce on windows, so this must be something specific to Mac. I've added some debug code that could help me a bit and confirm what it is that could be sticking for you.

Pull the latest rgthree-comfy and open ComfyUI with the following hash: http://127.0.0.1:8188/#rgthree-dev=true&rgthree-debug=true. Now, you should see a live view of the current keys rgthree-comfy things are being pressed in the top-right of the screen.

Can you confirm when you copy something that the keys stick as shown in that debug box even after you release? (As JoeNavark mentioned, if you leave the tab and come back, it should clear any down keys too).

• If you copy a node, is CMD and C stuck, or just C?
• What happens if you press CMD + C, but don't have any node to copy, etc?
• Are there other cases of CMD + ? that stick other than copy and paste.

It's not impossible that ComfyUI is intercepting and stopping the event so it can copy. It's not happening on windows with copy and paste, so if that's the case for Mac only then that would be wildly unfortunate. It could be something about Mac without ComfyUI's code either... though a bit odd on multiple browsers too... I'll keep digging here.

from rgthree-comfy.

Since I'm also on OSX, I tested a bit for you.

Copying a node or text with CMD+C will only cause the C key to get stuck. In fact, all combinations with the CMD (Meta) key will cause the associated key to get stuck. For example, if I use CMD+Enter to queue a prompt, the Enter key will get stuck. It doesn't appear to do that with any other key (Ctrl, Alt, Fn, ...).

Unfocusing the window (like switching tabs in the browser) will immediately unstick the key. Also, pressing the stuck key will unstick it as well. For example, if C is stuck after a CMD+C, I just have to press C to unstuck it.

from rgthree-comfy.