Giter VIP home page Giter VIP logo

Comments (4)

rhalff avatar rhalff commented on August 16, 2024

A key with dots is ambiguous, e.g how should this work:

const object = {
  foo: {
    bar: 'baz',
  },
 'foo.bar': 'baz,
}

Perhaps adding an escape makes sense? (not currently supported)

dot.pick('foo\.bar', object)

from dot-object.

thierry2015 avatar thierry2015 commented on August 16, 2024

I do not think that escaping would make sense since some strings and objects may come from an external source that is not aware of the plugin.

How about this:

const object = {
    foo: {
        bar: 'one'
    }
    'foo.bar': 'two',
    'some.thing': 'three'
};

dot.pick('foo.bar', object); // "one"
dot.pick('some.thing', object); // "three"
object['foo.bar']; // "two"

We could prefer sub-properties to dotted properties since they are way more frequent. So, if there is an ambiguous situation, this would need additional code by the developer. And I think that it would be simpler to implement.

As soon as the property cannot be resolved, we go with the next iteration and concatenate the previous key with the current one.

from dot-object.

rhalff avatar rhalff commented on August 16, 2024

Perhaps it's better to solve it in your own code:

const value = object['foo.bar'] || dot.pick('foo.bar', object);

For the other methods like set, move transfer etc. the behavior would become rather unpredictable.

from dot-object.

cburatto avatar cburatto commented on August 16, 2024

Sorry to reopen this here:

@rhalff you mention "it's better to solve it in your own code" but we don't always know the object schema.
Is it possible to implement the following?

const object = {
    foo: {
        bar: 'one'
    },
    'foo.bar': 'two',
    'some': {
        'other.node': {
            is: 'three'
        }
    }
}

let value = dot.pick('some["other.node"].is', object);

// three

This is similar to what I would do in code, and it should cover scenarios where the property has spaces and characters that might be used as alternative separators https://github.com/rhalff/dot-object#using-a-different-separator

This could work interchangeably, even for non-dotted properties:

dot.pick('foo.bar', object) === dot.pick('["foo"]["bar"]', object)

dot.pick('["foo.bar"]', object) === object["foo.bar"]

from dot-object.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.