Instant crashes on NixOS about regreet HOT 18 CLOSED

f8022a0 seems to be the bad commit.

from regreet.

Huh, strange. I was thinking of opening an issue with upstream GTK due to the bug that @fufexan helped narrow down, but put off since they wanted a minimal reproducible code with the bug.

I guess they fixed it in the meantime, and so I'm going to close this. Let me know if it still affects a few people, and then I'll re-open it.

from regreet.

Could you clear the log file, and attach one with the failing session/v0.1.1? The sessions at the start and at the end are all successful sessions.

from regreet.

regreet_log.txt
It's probably repeated about 7 times. That's the count it took for me to login to another tty and stop greetd.

from regreet.

The logs aren't revealing anything. Is there anything elsewhere, like greetd/sway/systemd logs? If not, you might have to bisect this. Try commit ccffff8, because everything up till then should just be fixes.

from regreet.

ccffff8 works fine. I've now started bisecting, checking f8022a0.

from regreet.

Ah, so it's the multi-monitor thing. A few more questions:

• How many monitors do you have?
• What's your GTK version?
• Could you post the terminal output of running ReGreet (within Sway/Cage)? There might be some GTK-related info.

from regreet.

• Only the builtin laptop screen at the time of the crashes
• ldd says libgtk-4.so.1 => /nix/store/yg6mrlwckqc24a3k6ds4hx56m4nq2lpm-gtk4-4.10.3/lib/libgtk-4.so.1
• I will try. In the meantime, I found something from dmesg

Jun 21 14:27:13 io kernel: traps: regreet[267527] general protection fault ip:7f270247da49 sp:7ffdd9187a10 error:0 in libgtk-4.so.1.1000.3[7f27020b9000+412000]

from regreet.

This is gonna be a weird debugging session, but:

1. Could you try building from the latest main branch, but after commenting out this line (add a // at the start of the line):

   ReGreet/src/gui/component.rs

   Line 374 in 61d871a

   root.fullscreen_on_monitor(monitor);

2. If it doesn't work, try additionally commenting out these lines (which removes the function post_view):

   ReGreet/src/gui/component.rs

   Lines 330 to 338 in 61d871a

   	fn post_view() {
   	if model.updates.changed(Updates::monitor()) {
   	if let Some(monitor) = &model.updates.monitor {
   	widgets.window.fullscreen_on_monitor(monitor);
   	// For some reason, the GTK settings are reset when changing monitors, so re-apply them.
   	setup_settings(self, &widgets.window);
   	}
   	}
   	}

3. If that still doesn't work, try adding return; right before this line (effectively ignoring the function choose_monitor):

   ReGreet/src/gui/model.rs

   Line 133 in 61d871a

   let display = match Display::open(display_name) {

Let me know which step worked for you.

from regreet.

Trying suggestion #1 it does not crash anymore. ReGreet is now "maximized" and not fullscreen (borders and titlebar are showing).

from regreet.

Okay, so for some reason, the GTK function fullscreen_on_monitor leads to a crash on your system. I'll have to investigate if that function has some caveats that apply to your case that I didn't consider. If I can't find any, we'll have to raise an issue upstream.

from regreet.

@rharish101 @fufexan I am having the same issue on NixOS unstable. For a long time I thought it was because NixOS had a new release, but using a different greeter works fine for now.

from regreet.

Sorry for the long delay. I couldn't find anything in the documentation about weird behaviours with fullscreen_on_monitor. Since it's been a while, @fufexan could you try with the latest GTK version? If it still doesn't work, I can open an issue upstream and tag you.

from regreet.

@rharish101 tried with the latest version in nixpkgs, and it behaves the same.

from regreet.

I have the same issue what I also noticed was that my themes aren't applied during the flickering as well. For some reason a workaround for this on sway seems to be to add this line to my sway config:

    output DP-1 pos 0 0

for reference my whole config:

    exec ${pkgs.dbus}/bin/dbus-update-activation-environment --systemd --all

    output DP-1 pos 0 0

    input * {
      xkb_numlock enabled
    }
    seat seat0 xcursor_theme Bibata-Modern-Classic 24
    xwayland disable

    bindsym Mod4+shift+e exec swaynag \
      -t warning \
      -m 'What do you want to do?' \
      -b 'Poweroff' 'systemctl poweroff' \
      -b 'Reboot' 'systemctl reboot'

    exec "${lib.getExe config.programs.regreet.package} -l debug; swaymsg exit"

The workaround might be a fluke that happened a lot in succession, because the bug itself isn't something I'm able to reproduce consistently which leads me to think that the issue has something to do with how my monitors behave.

EDIT: I am sorry lately my "workaround" isn't really working. With cage at least greetd properly crashes and restarts until it works. There has also been an instance where I was able to see an error that the GTK-theme couldn't be applied.
I hope a fix is found soon.

from regreet.

I just enabled this software in my NixOS config, and it runs fine without crashing.

from regreet.

can confirm this issue is solved for me, too

from regreet.

Works for me on NixOS 24.05 with Hyprland, on Regreet 0.1.1, the only issue that occurs for me is #11.

from regreet.