Getting the current activity about actionbarextras HOT 5 CLOSED

I tried adding this to the module without success:

@Kroll.method(name = "getActivity")
public ActivityProxy getActivityProxy() {
return super.getActivityProxy();
}

The activity I get contains an empty actionbar, which is useless... 👎
I don't understand what's the difference, since getActivityKroll method in TiWindowProxy is also calling KrollProxy's getActivityProxy...

PS: using Ti 3.4.0.GA

from actionbarextras.

Hi @PierreGUI

It's in the nature of things that you have to wait until a window is open before you can access its activity in Titanium. This being the case, your workaround seems to be a little vague if I'm not missing some context. How do you ensure that the window is open after 100ms? The window's open event gives you the appropriate timing to access the activity. I'd rather use that than using a timeout.

The same applies to accessing the action bar through this module. Don't use it before the window is open. Otherwise it would refer to the wrong activity. Please have a look at the example here, it's doing nothing else.

Now, with regard to your request, I don't think it's a good idea to implement a getter for the current activity into this module. Titanium already has an API for this: Ti.Android.currentActivity

How would you know which window belongs to the activity (and vice versa)?

Best,
Manuel

from actionbarextras.

Hey manumaticx thanks for your answer !
The example is bad code indeed, and I omitted to precise this code is executed after the postLayout so the window is already opened. Anyway, it happens quite often that the window's activity is not ready, throwing errors because onCreateOptionsMenuor invalidateOptionsMenu doesn't exists. That's why I came with this, and even if it works I want to make it reliable.

I'm gonna give Ti.Android.currentActivity another try, but I remember having issue (maybe it doesn't work with alloy?). Following your example, I'll also try configuring my window's actionbar when the open event is triggered.

I'll give you some feedback!

from actionbarextras.

Well, as I said before, I may missed some context as I don't know your code. But if you aim to access the actionBar, onCreateOptionsMenu or invalidateOptionsMenu of an activity always reference it via Ti.UI.Window.activity after the open event. This is the only way that works and the only way to ensure using the correct activity. Using Ti.Android.currentActivity you'll never know what window it belongs to or if it even has optionsMenu or actionBar defined.

from actionbarextras.

Works flawless. Can't realise it was so simple... Thanks a lot for your help!

from actionbarextras.