Comments (7)
I'll take a look at this in my latest devel version and see what I can do.
With gcc/clang I *always* compile with -fno-strict-aliasing, like the Linux
kernel:
https://lkml.org/lkml/2003/2/26/158
http://www.mail-archive.com/[email protected]/msg01647.html
If you look at miniz's CMakeLists.txt, it uses -fno-strict-aliasing.
Original comment by [email protected]
on 2 Dec 2013 at 3:06
from miniz.
This should be fixed now
from miniz.
There are still errors when compiling with -fstrict-aliasing
on 35c2d67:
miniz.c: In function ‘tdefl_find_match’:
miniz.c:1348:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
mz_uint16 c01 = TDEFL_READ_UNALIGNED_WORD(&d->m_dict[pos + match_len - 1]), s01 = TDEFL_READ_UNALIGNED_WORD(s);
^~~~~~~~~
miniz.c:1365:13: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
TDEFL_PROBE;
^~~~~~~~~~~
miniz.c:1366:13: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
TDEFL_PROBE;
^~~~~~~~~~~
miniz.c:1367:13: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
TDEFL_PROBE;
^~~~~~~~~~~
miniz.c:1391:13: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
c01 = TDEFL_READ_UNALIGNED_WORD(&d->m_dict[pos + match_len - 1]);
^~~
miniz.c: In function ‘mz_zip_validate_file’:
miniz.c:4935:9: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
has_id = (MZ_READ_LE32(descriptor_buf) == MZ_ZIP_DATA_DESCRIPTOR_ID);
^~~~~~
from miniz.
This can be alleviated by disabling the broken MINIZ_USE_UNALIGNED_LOADS_AND_STORES
option in the config until a proper fix is in place.
from miniz.
The issue still does not solve.
So what should I do? Disable the warning in code or I must compile with -fno-strict-aliasing?
from miniz.
Ok, sorry. Either set MINIZ_USE_UNALIGNED_LOADS_AND_STORES to zero (less performance on x86/x64), set -fno-strict-aliasing or ignore the warning. The warning should be a false positive.
from miniz.
Thanks for reply.
So it safe to disable the warning.
from miniz.
Related Issues (20)
- Possibility to seek within iterative decompression HOT 1
- tinfl_decompress_mem_to_heap fails to decompress any input due to early exit in tinfl_decompress
- example-1 not working in ESP32 - compression failed HOT 1
- mz_zip_add_mem_to_archive_file_in_place() creates duplicate file entry if file being added already exists in archive HOT 3
- MS Word files created with mz_zip_add_mem_to_archive_file_in_place() fail to open
- Miniz Errors in xtr1common
- How do I use this library? HOT 1
- Can I read some child files from a zip file, with a few limitation?
- mz_version() defined without prototype, causing warning, when MINIZ_NO_ZLIB_APIS defined
- Change crc32 define to something not so common.
- amalgamate.sh doesn't work on linux + musl-libc + arm64 systems, please provide a simple amalgamation command that works HOT 2
- Uninitialized variable: r->m_num_bits
- Minor issues compiling and running on a retro computer
- Compressing with small window size
- Integrity check fail on a ZIP64 file
- It does not seem to support decompressing the decompressed package of the split volume
- Compiler warnings on 32-bit HOT 1
- [Feature Request] Allow `mz_zip_writer_add_mem_ex_v2` to write metadata without requiring payload (`pBuf`)
- High inflate memory usage HOT 4
- We would like to ask you to add the newly released algorithm.(ECCPOW)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miniz.