'NoneType' object has no attribute 'startswith' if no images about django-thumbor HOT 7 CLOSED

Hi @pythdasch, does it make sense to add this check?

What do you expect to happen when you pass None as a URL?

Your code should probably check this before calling the function or using the templatetag.

from django-thumbor.

I'm closing the issue ok? Feel free to comment.

from django-thumbor.

I agree with you but why not adding some exceptions ?

Thanks for the reply :)

from django-thumbor.

IMHO it's an unnecessary complexity, it's something that can be done outside the lib.

from django-thumbor.

By the way, I also have some changes that I made to fix the fact that sometimes we serve the media locally and to make it work in production I had to add :
def _prepend_media_url(url):
if url.startswith(settings.MEDIA_URL):
url = _remove_prefix(url, settings.MEDIA_URL)
url.lstrip('/')
return '%s/%s' % (conf.THUMBOR_MEDIA_URL, url)
return url

def _prepend_static_url(url):
if url.startswith(settings.STATIC_URL):
    url = _remove_prefix(url, settings.STATIC_URL)
    url.lstrip('/')
    return '%s/%s' % (conf.THUMBOR_STATIC_URL, url)
return url


def generate_url(image_url, **kwargs):
# if settings.DEBUG:
#     if not "http" in image_url:
#         dt = datetime.now()
#         image_url = "http://lorempixel.com/g/1000/1000/?%s"%(dt.microsecond)

image_url = _prepend_media_url(image_url)
image_url = _prepend_static_url(image_url)
image_url = _remove_schema(image_url)

kwargs = dict(conf.THUMBOR_ARGUMENTS, **kwargs)
thumbor_server = kwargs.pop(
    'thumbor_server', conf.THUMBOR_SERVER).rstrip('/')
encrypted_url = crypto.generate(image_url=image_url, **kwargs).strip('/')
return '%s/%s' % (thumbor_server, encrypted_url)

from django-thumbor.

Looks good @pythdasch, it could help others.

Would like to send a pull request with this code and tests?

from django-thumbor.

yes i could!
Le 17 mai 2016 19:31, "Enrico Batista da Luz" [email protected] a
écrit :

Looks good @pythdasch https://github.com/pythdasch, it could help
others.

Would like to send a pull request with this code and tests?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#7 (comment)

from django-thumbor.