Error handling and automatic reconnect about riemann-nodejs-client HOT 12 CLOSED

Interesting, I don't recall, does it throw when connect fails? In the past, I've just created a facade object which attempts riemann if a config for it is present, otherwise it pipes to STDOUT. I don't think I like the idea of queuing events, but maybe.

from riemann-nodejs-client.

Yep - it throws when connect fails. I'm using this to cover it up for now:

client.tcp.socket.on 'error', (e) ->
  logger.warn "Riemann TCP error: #{e.message}"

... but then obviously it doesn't reconnect.

from riemann-nodejs-client.

I'm not sure I like the idea of queuing events either. I thought it might make sense because the client generates a timestamp, but you're still going to get a flood of events which will mess up aggregations etc.

from riemann-nodejs-client.

honestly, reconnecting is a weird request since we're in general using UDP, perhaps we just need the ability to be in "mixed" mode?

from riemann-nodejs-client.

Though it seems to connect with TCP on initialisation? In a way I'd rather it didn't connect with TCP by default – I just want to send "fire-and-forget" metrics.

from riemann-nodejs-client.

I think you can just do that, you don't have to care about the TCP connection if you don't want to. 😄

from riemann-nodejs-client.

It still throws an error on connect though - perhaps that needs some documentation?

from riemann-nodejs-client.

sure, because it can't connect to TCP, but that doesn't mean its a fatal error. We can update the docs yeah, can you propose a change?

from riemann-nodejs-client.

Sorry - I think you're misunderstanding. The problem is it is a fatal error. I'm very happy to do the work, I just want to make sure it's okay with you. :)

I suppose there are a bunch of options:

• Don't connect with TCP by default
• Handle connection errors to TCP and attempt to reconnect automatically.
• Document the fact that errors need to be handled, perhaps add an API for it too so you don't have to dig down to the socket.
• Something else? Not sure.

from riemann-nodejs-client.

can you send me the exact fatal error you're getting, I don't personally throw anything, so I assume its coming from node's TCP library then. I think I'd prefer a background polling of TCP, but we'd need to make sure than any usage of TCP get's somehow notified that its going to fail automatically.

from riemann-nodejs-client.

Error: connect ECONNREFUSED
    at errnoException (net.js:770:11)
    at Object.afterConnect [as oncomplete] (net.js:761:19)

from riemann-nodejs-client.

Just realizing that this pull request probably fixes this bug. LMK if its still an issue.
#6

from riemann-nodejs-client.