rigoneri / indefinite-article.js Goto Github PK

Two occurrences of "aedhilmnorsx" should be "aefhilmnorsx" instead.

In the "Special cases where a word that begins with a vowel should be preceeded by 'a' " for-loop iteration

for(var i in regexes) //line ~55-60

gives this error in IE: "Syntax error in regular expression"

It seems like for-in iterates through not only the contents of the array but also other array properties.

When changed to this, the error is gone
for (var i=0; i < regexes.length; i++)

PS. This is my first time writing error report in GitHub (a new student), so pardon any mistakes. Thanks in advance.

This regex is not anchored:

    if (word.match(/(?!FJO|[HLMNS]Y.|RY[EO]|SQU|(F[LR]?|[HL]|MN?|N|RH?|S[CHKLMNPTVW]?|X(YL)?)[AEIOU])[FHLMNRSX][A-Z]/)) {
        return "an";
    }

It looks to me like this was intended:

    if (word.match(/^(?!FJO|[HLMNS]Y.|RY[EO]|SQU|(F[LR]?|[HL]|MN?|N|RH?|S[CHKLMNPTVW]?|X(YL)?)[AEIOU])[FHLMNRSX][A-Z]/)) {
        return "an";
    }

As it is, this matches "SR" in "GDSR applicant" and returns "an" for "an GDSR applicant".