[Bug]: BIT7Z_DISABLE_USE_STD_FILESYSTEM not working about bit7z HOT 4 CLOSED

Hi!
This is weird! The BIT7Z_DISABLE_USE_STD_FILESYSTEM is not used to define a preprocessor flag, it is used to decide which C++ standard version to use to build the library.

If you enable BIT7Z_DISABLE_USE_STD_FILESYSTEM in CMake, the project should be configured to use C++14, and thus the compiler should not give access to the std::filesystem library.
So the #if defined( __cpp_lib_filesystem ) and #if BIT7Z_CPP_STANDARD >= 17 && defined( __has_include ) conditions should be both false, and BIT7Z_USE_STANDARD_FILESYSTEM would never be defined.

I guess I can get CMake to define the BIT7Z_DISABLE_USE_STD_FILESYSTEM preprocessor flag and use the #ifndef BIT7Z_DISABLE_USE_STD_FILESYSTEM as you did.

from bit7z.

Update: I've pushed the fix to the hotfix/v4.0.6 branch.

Now using the BIT7Z_DISABLE_USE_STD_FILESYSTEM CMake option will define the namesake preprocessor flag, and will prevent bidefines.hpp from defining the BIT7Z_USE_STANDARD_FILESYSTEM.

The next patch version v4.0.6 will contain the fix.

from bit7z.

Thank you, it's important when not using cmake

from bit7z.

Released on v4.0.6.

Thank you, it's important when not using cmake

You're welcome!

from bit7z.