:protocol missing about ring-mock HOT 6 CLOSED

I found this when playing around with ring-spec - which is great btw. Is ring-mock deprecated now or does it just need a fix? Happy to send a PR.

from ring-mock.

Also, :query-string is generated as nil, which fails the spec.

(s/explain-str :ring/request (assoc (request :get "/") :protocol "HTTP/1.1"))
=>
In: [:query-string] val: nil fails spec: :ring.request/query-string at: [:query-string] predicate: :clojure.spec/unknown

from ring-mock.

Needs a fix, I think! Ring-Mock is still useful for creating non-generative request maps. The :query-string key should probably be missing if it's not set.

from ring-mock.

I don't know how you feel about the ring-mock project now, given that equivalent functionality could eventually form part of the ring-spec project (via generators). Personally, I like ring-mock and think it's worth keeping up-to-date. Feel free to delegate to me if you like, but I think the fixes are fairly trivial.

from ring-mock.

As far as I know, generators aren't designed for creating specific data structures, so Ring-Mock is still useful for creating non-generative request maps.

from ring-mock.

This should be fixed now that #12 has been merged.

from ring-mock.