wrap-stacktrace is awkward to call conditionally about ring HOT 5 CLOSED

To me that reads as if wrap-stacktrace should apply only in a production setting. Wouldn't the more natural usage be:

(trace/wrap-stacktrace (env/env :dev))

or at least:

(trace/wrap-stacktrace (not (env/env :production)))

from ring.

Good call; the option should probably be stated in the positive rather than the negative.

from ring.

Sorry for taking a while to notice this. I'm not getting notifications for the ring-clojure organization anymore.

from ring.

I think that this might not be the best idea...

The wrap-stacktrace middleware isn't the only middleware a developer might want to use only in development, and the idea of encasing an if-statement in every middleware function that might not be used in a production environment strikes me as redundant.

Instead, perhaps just factoring development middleware into a separate function could be a solution:

(defn wrap-dev-middleware [handler]
  (if (= (env :ring-env) "production")
    handler
    (-> handler
        wrap-stacktrace
        wrap-reload
        wrap-whatever-else)))

from ring.

Yeah, on further consideration this is probably too specific and not the right place for it.

from ring.