[Enhancement] Allow customizing of tables about laravel-attributes HOT 5 CLOSED

Would you give me a real scenario where you need to modify the core migrations please, since I can see it possible to always migrate the core migrations first, and then alter tables the way you want from within your application migrations..

from laravel-attributes.

I have some additional fields for the attributes table, so the user can create via frontend a new attribute and like Magento, the user can decide how to validate the field, if the field should be unique. This is just an example, but I think there are also other scenarios.

Yes, that would be also a way to go, but in my opinion it's more intuitiv to publish the migrations and edit them after.

But as I said, I just wanted to discuss this solution. I don't know what others may think, but I just know other packages do it in that fashion.

from laravel-attributes.

I still believe the current package architecture is good, and there's nothing limits you from doing so. Your scenario is actually a real case we had, and we already implemented such interface as a solution for users to create attributes and attach it to other entities, and we can't see any limitation even whenever we need to alter database structure. We like to separate architecture layers which in my own opinion is better for separation of concerns and layer isolation, without losing flexibility. You can check that interface package here: rinvex/cortex-attributes in case you're interested in trying it.. 😉 As always, use the dev-develop branch for all untagged packages! ⚠️

from laravel-attributes.

Okay fine :) Are you interested in a new datatype (decimal)? I would create a pull request in the next days/weeks.

But thank you for your time! I'll take a look at it.

from laravel-attributes.

Yeah sure, please go ahead and add that new data type. PRs are always welcome 🙏

from laravel-attributes.