Giter VIP home page Giter VIP logo

Comments (8)

rishabh9 avatar rishabh9 commented on June 1, 2024

@zhiwzhao The information provided is not sufficient for me to debug. Could you provide me with more details like:

  • Are you using the Play's default thread pool through out?
  • (Where required) are you using the HttpExecutionContext as mentioned here
  • Could you share some sample code?

from mdc-propagation-dispatcher.

smur89 avatar smur89 commented on June 1, 2024

Hey rishabh9,

I'm having a similar issue here with this approach as zhiqzhao, was wondering if you could help?

I've got a sample app running here where the issue is replicated.
https://github.com/smur89/MDCSampleApp

      <pattern>%d{ISO8601} [%-5level] %-60([%thread] %logger{5}) %mdc{X-UUID:--} - %msg%n%ex{20}</pattern>
2017-06-12 16:01:49,944 [INFO ] [ForkJoinPool-1-worker-9] application                        - - ApplicationTimer demo: Starting application at 2017-06-12T15:01:49.939Z.
2017-06-12 16:01:50,051 [INFO ] [application-akka.actor.default-dispatcher-5] a.e.s.Slf4jLogger - - Slf4jLogger started
2017-06-12 16:01:50,060 [INFO ] [ForkJoinPool-1-worker-9] p.a.Play                           - - Application started (Dev)
2017-06-12 16:01:50,109 [INFO ] [application-akka.actor.default-dispatcher-5] c.HomeController - - Logging
2017-06-12 16:01:50,111 [INFO ] [ForkJoinPool-3-worker-15] c.HomeController                  - - Logging in the Future!

I would expect The last two log statements here to have Request Ids associated with them. I've attempted to implement this MDC logging using both the Akka Dispatcher and ExecutionContext approaches, and both result in the same outcome.

Any help appreciated! Thanks

from mdc-propagation-dispatcher.

rishabh9 avatar rishabh9 commented on June 1, 2024

Thanks @smur89 for the sample app. I'll take a look and get back to you guys.

from mdc-propagation-dispatcher.

rishabh9 avatar rishabh9 commented on June 1, 2024

I have spent whole two days on this already and don't have an answer/solution yet. Will keep you updated.

from mdc-propagation-dispatcher.

smur89 avatar smur89 commented on June 1, 2024

Just saw your reply @rishabh9, thanks for taking the time to have a look.

from mdc-propagation-dispatcher.

scozv avatar scozv commented on June 1, 2024

hi all, I found the solution for tracking id missing, and created this PR to @smur89 's demo repo.

That is a simple code change, but toke me some time to investigate. Anyway I started to log the tracking id on my owned project. this is a good news.

from mdc-propagation-dispatcher.

rishabh9 avatar rishabh9 commented on June 1, 2024

@scozv Thanks for the update! Really appreciate it. I will try the changes on my side as well and update you all. :)

from mdc-propagation-dispatcher.

smur89 avatar smur89 commented on June 1, 2024

Thanks @scozv, I have tried this out in a branch and it solved my issues 🥇

from mdc-propagation-dispatcher.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.