Giter VIP home page Giter VIP logo

Comments (5)

ritchie46 avatar ritchie46 commented on June 20, 2024

Ah right, that seems like an edge case I haven't properly tested. I will take a look at your PR. Seems valid so far.

from anastruct.

ritchie46 avatar ritchie46 commented on June 20, 2024

@smith120bh , is there any news on this?

from anastruct.

smith120bh avatar smith120bh commented on June 20, 2024

@ritchie46 : So the diff above is complete and works from my testing. I am unable to create a pull request, as I get an error saying that I don't have write access to your repository any time I try!

from anastruct.

ritchie46 avatar ritchie46 commented on June 20, 2024

@ritchie46 : So the diff above is complete and works from my testing. I am unable to create a pull request, as I get an error saying that I don't have write access to your repository any time I try!

Yeah you need to create a Pull Request from a fork from your repo. Could you try that? That saves me some copy pasting. ;)

from anastruct.

smith120bh avatar smith120bh commented on June 20, 2024

Ah, thanks! I've done a lot of work on Github, but have never actually wanted to change more than a couple lines of code in someone else's repository before... But now done! You should be able to test and eventually merge that PR now :-)

from anastruct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.