Comments (8)
Per discussion with @xforever1313 tonight, easiest way to do this is likely to handle it in constructor of Imgur class and set the environment variable there.
from teleirc.
We may want to figure out a short-term change for #87, whether that be removing unused imgur calls, or commenting out the current unworking Imgur implementation.
from teleirc.
@Tjzabel Theoretically, we could merge #87 so master
branch technically "works" again (this fixes the issue with #rit-foss
and #ritlug
for example). Before cutting a new release, we'd need to get to the bottom of this.
from teleirc.
@jwflory yeah we'll need to set the client ID in the env file and then pass it into the Imgur class.
I'm working on the upload function, and should have it by the end of the week unless someone finishes it before me.
from teleirc.
@Tjzabel Awesome! If you're already working on, I will assign this issue to you. 👍
from teleirc.
Update
Imgur standalone implementation is just about complete.
(Updated) Next Steps
- Make
TgImgurPhotoHandler.js
use the imgur Client ID from the.env
file. - Fix imgur tests -- RITlug test images URLs don't exist
- ???
- Profit!
from teleirc.
... I had a confusion
(I've just provisioned my own teleirc test bot to test out these issues)
In my infinite wisdom, I thought the imgur support was broken. After testing in my own environment, I have learned the opposite 😄 The imgur test cases fail, which had further confirmed my initial theory.
But now everything is all good!
It seems all we need to implement is the imgur client ID.
The client ID is the API key that is used to signal to imgur what application is making the calls. We should definitely be using the one in the .env
file.
Also, the test cases are failing because the test images on RITlug's website (https://ritlug.com) do not contain these test images anymore.
My realization makes this issue much easier and quicker to solve. I am going to update the above roadmap.
from teleirc.
Imgur photo uploading works.
from teleirc.
Related Issues (20)
- Authorized... EOF... die HOT 5
- teleirc exits with code 0/success even on failure HOT 2
- Add an option for the bot to show the part/join messages for certain users
- Requires super-new glibc -- will not run on Debian HOT 4
- Spam prevention HOT 2
- ban evasion bug. user can pm the bot and send messages to irc without being in the group
- Add Arch Linux Mexico to the "Who uses TeleIRC?" page.
- RELAYMSG support when supported by the IRCd
- IRC ACTION statements do not appear on Telegram correctly
- Relay HOT 1
- Create unit tests for IRC action handler functionality
- teleirc's v2.2.0 does not provide a binary relase breaking the 'teleirc-bin' AUR package. HOT 3
- "SASL authentication failed" error message when attempting to connect to an IRC channel HOT 2
- SASL support to log into irc.libera.chat HOT 4
- teleirc shows the telegram nicknames in the Telegram with unneeded space HOT 2
- IRC Raw Log HOT 1
- IRC - TLS Client Certificates HOT 2
- IRC - Allow setting user modes HOT 2
- Cannot join registration-required channels HOT 3
- Relay announces own IRC join HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from teleirc.