Giter VIP home page Giter VIP logo

Comments (9)

ritschwumm avatar ritschwumm commented on June 3, 2024

not sure what you mean - i don't see anything commented out there except in line 2 and 3?

from commonist.

tbertels avatar tbertels commented on June 3, 2024

Indeed, I confused # with the comments marker.

So then I don't understand why "{{Information" wasn't detected here: https://commons.wikimedia.org/w/index.php?title=File:10_-_Langhemarcq_-_Langemark.jpg&action=edit&oldid=316403155

from commonist.

tbertels avatar tbertels commented on June 3, 2024

It only checks upload.description, so if a custom description is used in common.description, it's not taken into account.

from commonist.

ritschwumm avatar ritschwumm commented on June 3, 2024

it might not be detected because if (!upload.description.startsWith("{{Information")) { relies on the description to start with the template, whereas on that page there's an == {{int:filedesc}} == before that.

from commonist.

ritschwumm avatar ritschwumm commented on June 3, 2024

or is the information template in the common.description in your case? btw, you do know you can replace the image_wikimedia_commons.bpp template locally to play with alternative versions, without modifying the packaged application?

from commonist.

tbertels avatar tbertels commented on June 3, 2024

That page was created by Commonist, with == {{int:filedesc}} == being https://github.com/ritschwumm/commonist/blob/master/src/main/resources/image_wikimedia_commons.bpp#L5
Indeed, the custom description was in common.description.

I tried to, but couldn't find the folder on Windows. A drawback of webstart is that the folder isn't in \Program files\.

from commonist.

tbertels avatar tbertels commented on June 3, 2024

But now that I think about it, I wonder if "Custom description" checkboxes shouldn't be added to disable the other fields.
Currently, this custom description feature is a hidden feature.

from commonist.

ritschwumm avatar ritschwumm commented on June 3, 2024

the custom resources directory is in a directory named .commonist inside whatever directory the java system property user.home says. if you start the commonist manually (either from the capsule jar or from the start-script) it will log a line INFO("settings directory", settingsDir) with the full directory name into your console.

from commonist.

tbertels avatar tbertels commented on June 3, 2024

I completely forgot to check on the website. You may want to mention it in the README file and in the repository description by the way.

from commonist.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.