mocking request loses original koa app instance, breaking resolving of req.subdomains, because req.app.subdomainOffset is undefined about koa-passport HOT 4 OPEN

With the latest version of koa (2.11) it also breaks req.ip because it depends on req.app.proxyIpHeader and app is mocked into an almost empty object.
I guess the second approach you've suggested would be the correct one, that's the most logical thing to do in my opinion.

from koa-passport.

Sorry for the late reply. What is your feeling, what the best solution would be? Extend the app mock to support your (totally valid!) use-case. Or replace the app mock with the original app, but monkey patch the original app to support express' trust proxy setting (thanks for already pointing out the commit where this change has been introduced)?

from koa-passport.

Just had this problem when using req.ip in my strategy.
Any news about this one ?

from koa-passport.

Any update?

from koa-passport.