Comments (8)
yes! Im my growing PR for pro #92 there is a commit for it
from meetupr.
in your PR it is an argument, not an option yet or am I missing something?
I mean that the default value of the argument would be something with getOption("meetupr.verbose")
from meetupr.
ah right, sorry I misunderstood. I'm not so used to working with options rather than arguments, so I'm not sure what would be the best, tbh. I'll let you decide.
from meetupr.
or, we could make FALSE the default, or make it TRUE by default when the session is interactive. 🤔
from meetupr.
what I like with arguments is that is more straight forward for the user how to silence it if they want, options can be a little less accessible.
from meetupr.
I'd still have both, since the argument would read the option, you could still use the argument.
from meetupr.
ok, that sounds like a nice idea
from meetupr.
I'll wait until your PR is merged since it introduces the verbose argument.
I think its default value should be verbose = getOption("meetupr.verbose", rlang::is_interactive())
- this way one can still use the argument
- one can toggle the value via a project/user level Rprofile
- the default is still TRUE in interactive session.
rlang::is_interactive()
can be mocked in tests so easier to test we supress messages when we should.
from meetupr.
Related Issues (20)
- Add internal functions for handling pagination HOT 2
- Fill in NEWS.md file with recent updates HOT 3
- Error in !cache : invalid argument type HOT 5
- Off-by-one error in fetch_results pagination handler HOT 5
- Add a test that we return the correct number of results HOT 13
- Problems with values for `event_status` in get_events()
- Add missing LICENSE.md file HOT 3
- Add GraphQL support HOT 11
- hexagon logo
- GraphQL: Can not find groups for a particular topicId HOT 2
- GraphQL: Missing group's organizer name / organizer id
- GraphQL: Groups needs followup query for location information HOT 1
- GraphQL: `get_boards()` can not be replicated
- Make an RData file to preserve old API results format HOT 5
- GraphQL: Find event attendees GraphQL query
- Unauthorized error HOT 11
- cleanup code remains from REST API
- graphql inconsistent response HOT 3
- Not able to locate meetup-token.rds when running examples
- Do we remove the deprecated.R file before CRAN release? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meetupr.