Giter VIP home page Giter VIP logo

Comments (8)

drmowinckels avatar drmowinckels commented on August 28, 2024

yes! Im my growing PR for pro #92 there is a commit for it

from meetupr.

maelle avatar maelle commented on August 28, 2024

in your PR it is an argument, not an option yet or am I missing something?

I mean that the default value of the argument would be something with getOption("meetupr.verbose")

from meetupr.

drmowinckels avatar drmowinckels commented on August 28, 2024

ah right, sorry I misunderstood. I'm not so used to working with options rather than arguments, so I'm not sure what would be the best, tbh. I'll let you decide.

from meetupr.

maelle avatar maelle commented on August 28, 2024

or, we could make FALSE the default, or make it TRUE by default when the session is interactive. 🤔

from meetupr.

drmowinckels avatar drmowinckels commented on August 28, 2024

what I like with arguments is that is more straight forward for the user how to silence it if they want, options can be a little less accessible.

from meetupr.

maelle avatar maelle commented on August 28, 2024

I'd still have both, since the argument would read the option, you could still use the argument.

from meetupr.

drmowinckels avatar drmowinckels commented on August 28, 2024

ok, that sounds like a nice idea

from meetupr.

maelle avatar maelle commented on August 28, 2024

I'll wait until your PR is merged since it introduces the verbose argument.

I think its default value should be verbose = getOption("meetupr.verbose", rlang::is_interactive())

  • this way one can still use the argument
  • one can toggle the value via a project/user level Rprofile
  • the default is still TRUE in interactive session.
  • rlang::is_interactive() can be mocked in tests so easier to test we supress messages when we should.

from meetupr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.