global options.options clobbered by binding options.options not individually overriden about knockout-sortable HOT 6 CLOSED

Thanks for this. I'll look at merging it in tonight with hopefully some tests to go with it.

from knockout-sortable.

@nezda In this case that there is a sub-option defined at the global level and also in the binding (same option), I think that we would want the one in the binding to win. Do you agree? Thanks.

from knockout-sortable.

I definitely agree. Unless I made a mistake, this patch should do that.

from knockout-sortable.

@nezda - this line: ko.utils.extend(value.options, ko.bindingHandlers.sortable.options); will overwrite existing options passed into the binding with the global options. So, the result will be merged, but options specified both in the binding and globally will end up being taken from the global setting.

We would probably need to create a copy of the global options using extend, then apply the local settings to it, then replace the local settings with this new merged copy.

from knockout-sortable.

Yikes, you are right, that code didn't do exactly what I intended. I agree with your proposed solution. I will revise my copy and submit another pull request.

from knockout-sortable.

@nezda Thanks again for reporting this one and submitting the pull request. I made the fix using logic similar to what we discussed.

from knockout-sortable.