Sorting is funky with string literals about knockout-sortable HOT 9 CLOSED

also "falsy" values in the array such as false, 0, undefined prevents updating the observable array even though the ui drop seems to happen.

from knockout-sortable.

Interesting enough I just came across an issue that might be related to this.

from knockout-sortable.

I think that this is definitely something that should be fixed. I will have to look into it a bit. The sourceIndex that is currently available is retrieved by using indexOf, which will just find the first one when dealing with primitives. I will need to hook into the "start" event and try to determine the index of the original element that is being dragged.

from knockout-sortable.

please note that if the array contains observable values, after drop the whole array will be wiped out. i think you should not make any assumptions on the array values but move (remove/insert) them by index.

from knockout-sortable.

@kicsiede - I agree, if I can get the appropriate index, then I will definitely move away from using remove.

from knockout-sortable.

Thanks for this.
A small problem: if you run this fiddle http://jsfiddle.net/rniemeyer/AC49j/ with current knockout-sortable.js you'll see it throws an error.

from knockout-sortable.

unfortunately you are still making assumptions on the values in several places
see this fiddle: http://jsfiddle.net/fnxaY/
the problem is at
2f2ea98#L0R140
2f2ea98#L0R161
that i could spot, you make decisions based on the falsiness of the value.
(2f2ea98#L0R70 this can also cause a problem)

from knockout-sortable.

@cuu508 - there was an issue with draggables, as they don't have a source array. This is fixed. I updated the fiddle with the latest files.

from knockout-sortable.

@kicsiede - looks like there is a bit more work to do to properly support falsey values (0, false, null, undefined, NaN, ""). I have an idea of how to handle it though. Going to open a separate issue for it.

from knockout-sortable.