Infinite Scroll Callback about salvattore HOT 5 CLOSED

I don't see a reason why you couldn't use a general infinite scroll solution in this case.

from salvattore.

The error is here:

salvattore['append_elements'](container, [newElements]);

It should be:

salvattore['append_elements'](container, newElements);

Let me know how it went.

from salvattore.

bump

from salvattore.

bump - any updates on this?

from salvattore.

The callback function of Infinite Scroll should reference the grid as a DOM element, not a jQuery object, and pass the new elements as such:

$('#grid').infinitescroll({
     appendCallback: false
  },
  function(newElements) {
    salvattore['append_elements'](document.getElementById('grid'), newElements);
});

Then update line :257 of salvattore.js:

  elements.forEach(function append_to_next_fragment(element) {

Which is attempting to loop over an object as an array, causing all sorts of problems, to the code below (which is used in the immediately following function anyway):

  Array.prototype.forEach.call(elements, function append_to_next_fragment(element) {

This works for me. I may have totally missed something obvious, and it may very well be that the actualy plugin code itself needs no updating, but this got it working for me. I'm going to create a pull request just incase this is actually the correct fix

👍

from salvattore.